Skip to content

chore(api): clarify computer call output identifiers - #732

Open
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-131
Open

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-131

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies computer call output ID documentation in models and type signatures.

Changes

  • Preserves required returned IDs and status, with optional IDs on input.

Castiron-Internal-PR: openai/openai-ruby-internal#131
Castiron-Source-SHA: 5d0781ac605ef4ebc421546b7e76078985afb4d9
Castiron-Public-Base-SHA: 3343547
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

70 mixed files remain; 0 existing customizations changed.

Compared 33435479c2d9a3c7a066f5cf. Generated baselines verified.

70 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi

30 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35554208687 --repo openai/openai-ruby \
  --name castiron-custom-code-35554208687-1 --dir /tmp/castiron-custom-code-35554208687-1
git apply --stat /tmp/castiron-custom-code-35554208687-1/custom-code.patch
cat /tmp/castiron-custom-code-35554208687-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 33435479c2d98603b93c810183d314bc55cd1ee7 a3c7a066f5cf190e3f67ac92523ae9cdf25d7cf3
python3 scripts/castiron/custom_code_report.py report \
  --base 33435479c2d98603b93c810183d314bc55cd1ee7 \
  --head a3c7a066f5cf190e3f67ac92523ae9cdf25d7cf3 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-a3c7a066f5cf
cat /tmp/castiron-custom-code-a3c7a066f5cf/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 02:26
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 02:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T02:27:54.364535Z a3c7a06 Draft marked ready
🔒 Security Review Completed 2026-09-21T02:29:10.579936Z a3c7a06 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

236/236 SDK tests passed in 9.516s for Ruby SDK PR #732.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 168ms
tests/chat-completions-create.test.ts ✅ Passed 230ms
tests/chat-completions-stream.test.ts ✅ Passed 141ms
tests/files-content-binary.test.ts ✅ Passed 152ms
tests/files-create-multipart.test.ts ✅ Passed 135ms
tests/files-list-pagination.test.ts ✅ Passed 190ms
tests/initialize-config.test.ts ✅ Passed 96ms
tests/instance-isolation.test.ts ✅ Passed 199ms
tests/models-list.test.ts ✅ Passed 158ms
tests/responses-background-lifecycle.test.ts ✅ Passed 117ms
tests/responses-body-method-errors.test.ts ✅ Passed 448ms
tests/responses-cancel-timeout.test.ts ✅ Passed 276ms
tests/responses-cancel.test.ts ✅ Passed 243ms
tests/responses-compact-retries.test.ts ✅ Passed 235ms
tests/responses-compact.test.ts ✅ Passed 268ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 152ms
tests/responses-create-advanced.test.ts ✅ Passed 181ms
tests/responses-create-disconnect.test.ts ✅ Passed 158ms
tests/responses-create-errors.test.ts ✅ Passed 247ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 179ms
tests/responses-create-retries.test.ts ✅ Passed 166ms
tests/responses-create-stream-failures.test.ts ✅ Passed 147ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 240ms
tests/responses-create-stream-wire.test.ts ✅ Passed 2.208s
tests/responses-create-stream.test.ts ✅ Passed 161ms
tests/responses-create-terminal-states.test.ts ✅ Passed 295ms
tests/responses-create-timeout.test.ts ✅ Passed 285ms
tests/responses-create.test.ts ✅ Passed 253ms
tests/responses-delete.test.ts ✅ Passed 210ms
tests/responses-input-items-errors.test.ts ✅ Passed 176ms
tests/responses-input-items-list.test.ts ✅ Passed 211ms
tests/responses-input-items-options.test.ts ✅ Passed 143ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 252ms
tests/responses-input-tokens-count.test.ts ✅ Passed 258ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.437s
tests/responses-not-found-errors.test.ts ✅ Passed 350ms
tests/responses-parse.test.ts ✅ Passed 173ms
tests/responses-retrieve-retries.test.ts ✅ Passed 251ms
tests/responses-retrieve.test.ts ✅ Passed 229ms
tests/responses-stored-method-errors.test.ts ✅ Passed 778ms
tests/retry-behavior.test.ts ✅ Passed 3.494s
tests/sdk-error-shape.test.ts ✅ Passed 383ms

View OkTest run #35554193591

SDK merge (3361bb144116) · head (a3c7a066f5cf) · base (33435479c2d9) · OkTest (a0be4375e02d)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants