chore(api): clarify image fidelity and legacy image guidance - #730
markstuart-oai wants to merge 1 commit into
Conversation
Castiron custom code✅ No new custom-code files detected. 70 mixed files remain; 0 existing customizations changed; 1 generated baselines changed. Compared
69 existing customizations unchanged
29 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35566528413 --repo openai/openai-ruby \
--name castiron-custom-code-35566528413-1 --dir /tmp/castiron-custom-code-35566528413-1
git apply --stat /tmp/castiron-custom-code-35566528413-1/custom-code.patch
cat /tmp/castiron-custom-code-35566528413-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 33435479c2d98603b93c810183d314bc55cd1ee7 ccd88da67dbf3d7f504b141243b0e50dcadb0574
python3 scripts/castiron/custom_code_report.py report \
--base 33435479c2d98603b93c810183d314bc55cd1ee7 \
--head ccd88da67dbf3d7f504b141243b0e50dcadb0574 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-ccd88da67dbf
cat /tmp/castiron-custom-code-ccd88da67dbf/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Castiron-Internal-PR: openai/openai-ruby-internal#130 Castiron-Source-SHA: 4ea3e504beeefd6bfdfc61c1a4f47d05c7a10cd2 Castiron-Public-Base-SHA: 3343547
2306a54 to
ccd88da
Compare
Clarifies image fidelity guidance for image edits and image tools: the low default applies to models that support the parameter, mini retains its low-only exception, and unsupported models require omission. Identifies retired DALL·E settings and variations as legacy, and directs callers to supported image workflows with an explicit model choice.
No Ruby runtime behavior, signatures, enums, defaults, nullability, serialization, or exported names change.
Validation: the Ruby 3.3/3.4/4.0 test matrix, Bedrock tests, lint, RBI type checks, RBS validation and package checks pass. Token comparison confirms all Ruby and signature changes are documentation-only.