Skip to content

feat(api): add 30-minute cache-write usage counts - #4111

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-293
Oct 19, 2026
Merged

feat(api): add 30-minute cache-write usage counts#4111
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-293

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Expose 30-minute cache-write token counts in completions and Decisions usage results.

Changes

  • Add the optional input_cache_write_30m_tokens usage metric.
  • Allow the metric to be null or absent in older responses.

Validation

  • 16 synchronous/asynchronous transport cases pass; custom-code budget passes at 7,368 / 10,000 lines.
  • Handwritten tests cover 73, zero, explicit null, and omission, and preserve the existing cache-write counters. Isolated decoder mutations fail on the expected value; the unchanged candidates pass again.

@jbeckwith-oai
feat(api): add 30-minute cache-write usage counts
100fe43 
Castiron-Internal-PR: openai/openai-python-internal#293
Castiron-Source-SHA: 3f88414bf1f0e08a64642df215cb99b933363c26
Castiron-Public-Base-SHA: 6eaa90e
@github-actions

github-actions Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 6eaa90ee20b40bbe84a5b1a5031d7cf672c7d368.

Trusted main policy: 6eaa90ee20b40bbe84a5b1a5031d7cf672c7d368.

✅ No new custom-code files detected.

41 mixed files remain; 0 existing customizations changed.

Compared 6eaa90ee20b4 → 100fe43e882a. Generated baselines verified.

41 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/realtime/translations/translations.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/decision_input_image_param.py
  • src/openai/types/decision_input_text_param.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • src/openai/types/webhooks/live_call_incoming_webhook_event.py
  • src/openai/types/webhooks/unwrap_webhook_event.py

1 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39300344471 --repo openai/openai-python \
  --name castiron-custom-code-39300344471-1 --dir /tmp/castiron-custom-code-39300344471-1
git apply --stat /tmp/castiron-custom-code-39300344471-1/custom-code.patch
cat /tmp/castiron-custom-code-39300344471-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 6eaa90ee20b40bbe84a5b1a5031d7cf672c7d368 100fe43e882ab9d7af31322af116b8f8776b807f
python3 scripts/castiron/custom_code_report.py report \
  --base 6eaa90ee20b40bbe84a5b1a5031d7cf672c7d368 \
  --head 100fe43e882ab9d7af31322af116b8f8776b807f --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-100fe43e882a
cat /tmp/castiron-custom-code-100fe43e882a/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 19, 2026 18:09
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 19, 2026 18:09
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:11:16.875902Z 100fe43 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-19T18:12:19.056444Z 100fe43 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.665s for Python SDK PR #4111.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 250ms
tests/chat-completions-create.test.ts ✅ Passed 223ms
tests/chat-completions-stream.test.ts ✅ Passed 293ms
tests/files-content-binary.test.ts ✅ Passed 265ms
tests/files-create-multipart.test.ts ✅ Passed 252ms
tests/files-list-pagination.test.ts ✅ Passed 200ms
tests/initialize-config.test.ts ✅ Passed 174ms
tests/instance-isolation.test.ts ✅ Passed 184ms
tests/models-list.test.ts ✅ Passed 206ms
tests/responses-background-lifecycle.test.ts ✅ Passed 177ms
tests/responses-body-method-errors.test.ts ✅ Passed 275ms
tests/responses-cancel-timeout.test.ts ✅ Passed 246ms
tests/responses-cancel.test.ts ✅ Passed 167ms
tests/responses-compact-retries.test.ts ✅ Passed 301ms
tests/responses-compact.test.ts ✅ Passed 200ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 178ms
tests/responses-create-advanced.test.ts ✅ Passed 210ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.186s
tests/responses-create-errors.test.ts ✅ Passed 175ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 214ms
tests/responses-create-retries.test.ts ✅ Passed 225ms
tests/responses-create-stream-failures.test.ts ✅ Passed 208ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 237ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.997s
tests/responses-create-stream.test.ts ✅ Passed 158ms
tests/responses-create-terminal-states.test.ts ✅ Passed 263ms
tests/responses-create-timeout.test.ts ✅ Passed 243ms
tests/responses-create.test.ts ✅ Passed 189ms
tests/responses-delete.test.ts ✅ Passed 194ms
tests/responses-input-items-errors.test.ts ✅ Passed 345ms
tests/responses-input-items-list.test.ts ✅ Passed 281ms
tests/responses-input-items-options.test.ts ✅ Passed 258ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 254ms
tests/responses-input-tokens-count.test.ts ✅ Passed 243ms
tests/responses-malformed-inputs.test.ts ✅ Passed 1.063s
tests/responses-not-found-errors.test.ts ✅ Passed 240ms
tests/responses-parse.test.ts ✅ Passed 271ms
tests/responses-retrieve-retries.test.ts ✅ Passed 452ms
tests/responses-retrieve.test.ts ✅ Passed 195ms
tests/responses-stored-method-errors.test.ts ✅ Passed 434ms
tests/retry-behavior.test.ts ✅ Passed 3.03s
tests/sdk-error-shape.test.ts ✅ Passed 252ms

View OkTest run #39300225725

SDK merge (3894fab689be) · head (100fe43e882a) · base (6eaa90ee20b4) · OkTest (ebbcfaca8a5e)

markstuart-oai
markstuart-oai approved these changes Oct 19, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 100fe43e882ab9d7af31322af116b8f8776b807f.

The new cache-write counter stays optional and nullable across the generated response models. The focused tests cover positive, zero, null and omitted values through completions and Decisions, using both sync and async clients while preserving the existing counters.

No blocking findings. Source review only; I did not run the code or tests locally. Observed checks for this commit passed or were skipped.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 5589146 Oct 19, 2026
35 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-293 branch October 19, 2026 18:33
@openai-sdks openai-sdks Bot mentioned this pull request Oct 19, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbeckwith-oai @markstuart-oai