Skip to content

chore(api): use neutral moderation examples - #4104

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-283
Oct 18, 2026
Merged

chore(api): use neutral moderation examples#4104
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-283

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Use a generic placeholder for text in moderation examples.

Changes

  • Replace the explicit text example with a neutral placeholder.
  • Keep moderation parameters, response types, and behavior unchanged.

The moderation request uses a neutral placeholder. Its obsolete response example is removed because it described the previous input; response examples are optional. API parameters, response types, and endpoint behavior are unchanged.

@jbeckwith-oai
chore(api): use neutral moderation examples
ff26389 
Castiron-Internal-PR: openai/openai-python-internal#283
Castiron-Source-SHA: 5d54b52be87fe1f98c83329182cd818918c97f8d
Castiron-Public-Base-SHA: 547ecb1
@github-actions

github-actions Bot commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 547ecb1e4fc233f19030736c29fee4374dfbaca1.

Trusted main policy: 547ecb1e4fc233f19030736c29fee4374dfbaca1.

✅ No new custom-code files detected.

41 mixed files remain; 0 existing customizations changed.

Compared 547ecb1e4fc2 → ff2638944b3f. Generated baselines verified.

41 existing customizations unchanged
  • api.md
  • scripts/castiron/custom_code_budget.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/environments/files.py
  • src/openai/resources/beta/agents/sessions/artifacts.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/realtime/translations/translations.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/decision_input_image_param.py
  • src/openai/types/decision_input_text_param.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/tool.py
  • src/openai/types/responses/tool_param.py
  • src/openai/types/webhooks/init.py
  • src/openai/types/webhooks/live_call_incoming_webhook_event.py
  • src/openai/types/webhooks/unwrap_webhook_event.py

1 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39096314760 --repo openai/openai-python \
  --name castiron-custom-code-39096314760-1 --dir /tmp/castiron-custom-code-39096314760-1
git apply --stat /tmp/castiron-custom-code-39096314760-1/custom-code.patch
cat /tmp/castiron-custom-code-39096314760-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 547ecb1e4fc233f19030736c29fee4374dfbaca1 ff2638944b3f81d7bab637e70ffeeccc139eee5f
python3 scripts/castiron/custom_code_report.py report \
  --base 547ecb1e4fc233f19030736c29fee4374dfbaca1 \
  --head ff2638944b3f81d7bab637e70ffeeccc139eee5f --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-ff2638944b3f
cat /tmp/castiron-custom-code-ff2638944b3f/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 18, 2026 04:12
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 18, 2026 04:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T04:13:33.663036Z ff26389 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-18T04:14:59.115762Z ff26389 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Oct 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 9.03s for Python SDK PR #4104.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 138ms
tests/chat-completions-create.test.ts ✅ Passed 266ms
tests/chat-completions-stream.test.ts ✅ Passed 482ms
tests/files-content-binary.test.ts ✅ Passed 157ms
tests/files-create-multipart.test.ts ✅ Passed 196ms
tests/files-list-pagination.test.ts ✅ Passed 196ms
tests/initialize-config.test.ts ✅ Passed 184ms
tests/instance-isolation.test.ts ✅ Passed 196ms
tests/models-list.test.ts ✅ Passed 240ms
tests/responses-background-lifecycle.test.ts ✅ Passed 347ms
tests/responses-body-method-errors.test.ts ✅ Passed 256ms
tests/responses-cancel-timeout.test.ts ✅ Passed 205ms
tests/responses-cancel.test.ts ✅ Passed 249ms
tests/responses-compact-retries.test.ts ✅ Passed 331ms
tests/responses-compact.test.ts ✅ Passed 242ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 239ms
tests/responses-create-advanced.test.ts ✅ Passed 149ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.283s
tests/responses-create-errors.test.ts ✅ Passed 335ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 165ms
tests/responses-create-retries.test.ts ✅ Passed 466ms
tests/responses-create-stream-failures.test.ts ✅ Passed 736ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 214ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.716s
tests/responses-create-stream.test.ts ✅ Passed 174ms
tests/responses-create-terminal-states.test.ts ✅ Passed 233ms
tests/responses-create-timeout.test.ts ✅ Passed 218ms
tests/responses-create.test.ts ✅ Passed 210ms
tests/responses-delete.test.ts ✅ Passed 333ms
tests/responses-input-items-errors.test.ts ✅ Passed 471ms
tests/responses-input-items-list.test.ts ✅ Passed 388ms
tests/responses-input-items-options.test.ts ✅ Passed 208ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 248ms
tests/responses-input-tokens-count.test.ts ✅ Passed 148ms
tests/responses-malformed-inputs.test.ts ✅ Passed 981ms
tests/responses-not-found-errors.test.ts ✅ Passed 210ms
tests/responses-parse.test.ts ✅ Passed 256ms
tests/responses-retrieve-retries.test.ts ✅ Passed 161ms
tests/responses-retrieve.test.ts ✅ Passed 304ms
tests/responses-stored-method-errors.test.ts ✅ Passed 338ms
tests/retry-behavior.test.ts ✅ Passed 3.159s
tests/sdk-error-shape.test.ts ✅ Passed 223ms

View OkTest run #39096292354

SDK merge (be24e59b9856) · head (ff2638944b3f) · base (547ecb1e4fc2) · OkTest (ebbcfaca8a5e)

markstuart-oai
markstuart-oai approved these changes Oct 18, 2026
View reviewed changes

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed ff2638944b3f81d7bab637e70ffeeccc139eee5f. The neutral moderation examples and removal of the obsolete response example are consistent. The sync, async, raw-response, and streaming tests keep their assertions and request parameters; only the example input changes. API types and runtime code remain unchanged. No correctness or maintainability findings.

Validation: reviewed the complete pinned diff and surrounding tests, checked the transformed-spec structure, and verified generated-file hashes. Hosted Python 3.10/3.14 tests, HTTPX2 tests, lint, type checks, compatibility checks, and OkTest pass. I did not run candidate code or tests locally.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit 553703e Oct 18, 2026
33 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-283 branch October 18, 2026 04:31
@openai-sdks openai-sdks Bot mentioned this pull request Oct 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markstuart-oai markstuart-oai markstuart-oai approved these changes
@dpiet-oai dpiet-oai dpiet-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeckwith-oai @markstuart-oai @dpiet-oai