ci: standardize custom-code budget reporting - #4018
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#194 Castiron-Source-SHA: 4c76a24dc83e1f5081c2822c27d87e8d0dbc9fb1 Castiron-Public-Base-SHA: e5de2e5
Contributor
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed; 12 customizations removed; 19 generated baselines changed. Compared
40 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37027714203 --repo openai/openai-python \
--name castiron-custom-code-37027714203-1 --dir /tmp/castiron-custom-code-37027714203-1
git apply --stat /tmp/castiron-custom-code-37027714203-1/custom-code.patch
cat /tmp/castiron-custom-code-37027714203-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin e5de2e5656fb3d4fa70f050195382e6a4d59f806 2b754bbecf2fb94a8cff277411f56f95b51f1e7a
python3 scripts/castiron/custom_code_report.py report \
--base e5de2e5656fb3d4fa70f050195382e6a4d59f806 \
--head 2b754bbecf2fb94a8cff277411f56f95b51f1e7a --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-2b754bbecf2f
cat /tmp/castiron-custom-code-2b754bbecf2f/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
apcha-oai
marked this pull request as ready for review
October 2, 2026 15:32
apcha-oai
enabled auto-merge
October 2, 2026 15:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
markstuart-oai
approved these changes
Oct 2, 2026
markstuart-oai
left a comment
markstuart-oai
left a comment
Contributor
There was a problem hiding this comment.
Reviewed 2b754bbecf2f. This diff changes generated ownership headers, documentation, fixture formatting and generation metadata; the workflows and reporter are unchanged from its base. No introduced correctness or structural issue found, and no new 1,000-line crossing. The shared publication issues identified in the companion SDK reviews are already present in this PR's base, rather than introduced here.
Source-only review; no repository workloads run. All reported hosted checks in the inspected exact-head snapshot were successful or skipped, including the relevant custom-code checks. Approval covers this diff, not execution of the author's local tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the existing custom-code budget tooling with the shared generated templates, including generated-file headers, documentation, and publisher test-fixture formatting.
The existing API reference, runtime behavior, public API, and repository-owned budget policy remain unchanged.
Validation: SDK formatting and all 59 offline custom-code tests passed locally, including the compiler hash contract.