test: verify omitted and explicit Responses WebSocket preconnect - #3968
Merged
Merged
Conversation
Contributor
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36272294052 --repo openai/openai-python \
--name castiron-custom-code-36272294052-1 --dir /tmp/castiron-custom-code-36272294052-1
git apply --stat /tmp/castiron-custom-code-36272294052-1/custom-code.patch
cat /tmp/castiron-custom-code-36272294052-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 384fee3252e2336a85450ff38f9bae41f9199616 e515048e767a2d89f98fa2c47972c607e9e0bf7a
python3 scripts/castiron/custom_code_report.py report \
--base 384fee3252e2336a85450ff38f9bae41f9199616 \
--head e515048e767a2d89f98fa2c47972c607e9e0bf7a --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-e515048e767a
cat /tmp/castiron-custom-code-e515048e767a/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Contributor
dpiet-oai
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Responses WebSocket preconnect omission fix needs regression coverage across sync and async clients. Add one test file exercising both paths against real local WebSocket upgrades, so an absent optional query field cannot silently turn into an explicit false value. It also covers false and true when supplied.
The file is tests only, with no production, dependency or generated-code changes.
Validation on the committed test bytes: