chore(api): document stored chat completion errors - #3963
Conversation
Castiron-Internal-PR: openai/openai-python-internal#157 Castiron-Source-SHA: f030a962fb6aab04beba9f27c069780d82c7925c Castiron-Public-Base-SHA: 6e4a79c
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36170591942 --repo openai/openai-python \
--name castiron-custom-code-36170591942-1 --dir /tmp/castiron-custom-code-36170591942-1
git apply --stat /tmp/castiron-custom-code-36170591942-1/custom-code.patch
cat /tmp/castiron-custom-code-36170591942-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 6e4a79cc8c7e640e7ac4be710db32fe20b1020f2 8f80409efdccf04bc238530bc6a4442aa9128cec
python3 scripts/castiron/custom_code_report.py report \
--base 6e4a79cc8c7e640e7ac4be710db32fe20b1020f2 \
--head 8f80409efdccf04bc238530bc6a4442aa9128cec --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-8f80409efdcc
cat /tmp/castiron-custom-code-8f80409efdcc/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed 8f80409 against 6e4a79c. No actionable findings.
Independently parsed the complete base/head OpenAPI documents and verified that the entire semantic difference is exactly 17 added error-response entries across the five stored-chat operations (list, retrieve, update, delete, and list messages). Removing those entries makes the full documents equal. The ErrorResponse and TooManyRequests references resolve to unchanged existing components, and chat-completion creation/streaming definitions are unchanged.
Verified the transformed-document MD5 matches generation metadata (6e1ff6e06165d5b2e49cbfd336f00c20); only the expected five generation metadata fields changed. Both changed files were reviewed; no SDK implementation, public signatures, exception classes, or dependency files changed.
Validation was artifact-focused for this documentation-only change. I did not rerun the full SDK test suite or make live API calls.
|
Thanks for the independent review. Confirmed the reviewed head is unchanged: only the API reference and generation metadata differ from main. Python client code and exception handling remain byte-identical; the current CI and 236-case downstream compatibility run both pass. |
Summary
Clarifies error responses for stored chat completions without changing Python exception handling.
Changes