chore(api): document Responses not-found errors - #3959
Conversation
Castiron-Internal-PR: openai/openai-python-internal#154 Castiron-Source-SHA: f872a759fdea341b3aefdd8a36423d8aeee9239e Castiron-Public-Base-SHA: 09c5b6f
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed; 8 customizations removed; 8 generated baselines changed. Compared
47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36093684675 --repo openai/openai-python \
--name castiron-custom-code-36093684675-1 --dir /tmp/castiron-custom-code-36093684675-1
git apply --stat /tmp/castiron-custom-code-36093684675-1/custom-code.patch
cat /tmp/castiron-custom-code-36093684675-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 09c5b6f13f716ad4e417fd7ba9209a8a057e0383 da5ecb1b92f5e7b4d39e1c620b7414193155cdcd
python3 scripts/castiron/custom_code_report.py report \
--base 09c5b6f13f716ad4e417fd7ba9209a8a057e0383 \
--head da5ecb1b92f5e7b4d39e1c620b7414193155cdcd --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-da5ecb1b92f5
cat /tmp/castiron-custom-code-da5ecb1b92f5/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed da5ecb1. No blocking findings.
Verified the immutable base/head YAML with duplicate-key detection and semantic comparison: the only semantic changes are the eight stable/beta Responses 404 response definitions and the new required-error BetaErrorResponse wrapper. All new schema references resolve; the seed format relocation is semantically unchanged.
The full Git-tree comparison confirms that only the API-reference artifact and generation metadata changed, with no SDK runtime, public API, dependency, or workflow changes. The documented envelope agrees with the existing status-error handling.
Validation was artifact-focused; no live API calls or full SDK test suite were run locally.
|
@jbeckwith-oai Thank you for the exact-head review. It agrees with the full-tree and schema comparison at |
Summary
Document the JSON error envelope returned when a requested response or input-item cursor cannot be found.
Changes