feat(api): add vault metadata and clarify web search locations - #3950
marcuswood-oai wants to merge 1 commit into
Conversation
Castiron-Internal-PR: openai/openai-python-internal#145 Castiron-Source-SHA: 80e06b0d9b66811d33d846516b7b144132d887dc Castiron-Public-Base-SHA: 4d12746
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35922899291 --repo openai/openai-python \
--name castiron-custom-code-35922899291-1 --dir /tmp/castiron-custom-code-35922899291-1
git apply --stat /tmp/castiron-custom-code-35922899291-1/custom-code.patch
cat /tmp/castiron-custom-code-35922899291-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 4d1274681db7f34f671ff9e71adc1461d22a927b 1f09e2a5b85a8858d13afc6438107b99c1c6fdea
python3 scripts/castiron/custom_code_report.py report \
--base 4d1274681db7f34f671ff9e71adc1461d22a927b \
--head 1f09e2a5b85a8858d13afc6438107b99c1c6fdea --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1f09e2a5b85a
cat /tmp/castiron-custom-code-1f09e2a5b85a/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed at 1f09e2a. No actionable findings.
Reviewed the sync/async create and update body transforms, optional auth on updates, required response metadata, updated environment-credential fixture, and documentation-only web-search changes. The required response-metadata/model-construction change is the explicitly documented public-beta contract change, not an accidental omission.
Validation: 40 independent assertions against this head's actual transformed schema passed, including metadata key/value/count bounds and metadata-only, empty-map clearing, auth-only, and combined updates. Verified the complete semantic schema delta and generation hash. Exact-head hosted build/lint/test checks are green (conditional jobs are skipped). I did not rerun the full SDK suite locally.
|
Closing this broader update. A separate update will contain only the web-search approximate-location documentation changes. |
Summary
Adds vault credential metadata to credential results and create/update requests, including metadata-only updates. Clarifies web search location defaults.
Changes