Skip to content

docs: clarify collaborator-only pull request policy - #3948

Merged
jbeckwith-oai merged 2 commits into
mainfrom
codex/contribution-policy-20260923-openai-python
Sep 23, 2026
Merged

jbeckwith-oai merged 2 commits into
mainfrom
codex/contribution-policy-20260923-openai-python

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make the contribution guidance match the repository's collaborator-only pull request policy. The README links to CONTRIBUTING.md, both explicitly exclude PRs from non-collaborators, and community feedback goes through issues. Existing development instructions remain available to collaborators, and security reports continue through the private disclosure process.

Remove the conflicting invitation to external PRs from the pull request template.

Use absolute README links to the policy and security guide so package-page readers can follow them.

Test plan

  • git diff --check and targeted policy/link checks pass.
  • Reviewed the complete diff and contributor, collaborator, and private security-reporting paths.

Documentation only; no SDK runtime, repository settings, or generated source changes.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner September 23, 2026 16:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T16:09:08.665431Z d75764e PR opened
🔒 Security Review ✅ Completed 2026-09-23T16:10:12.609948Z d75764e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@openai-sdks

openai-sdks Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 11.513s for Python SDK PR #3948.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 172ms
tests/chat-completions-create.test.ts ✅ Passed 274ms
tests/chat-completions-stream.test.ts ✅ Passed 267ms
tests/files-content-binary.test.ts ✅ Passed 271ms
tests/files-create-multipart.test.ts ✅ Passed 200ms
tests/files-list-pagination.test.ts ✅ Passed 176ms
tests/initialize-config.test.ts ✅ Passed 186ms
tests/instance-isolation.test.ts ✅ Passed 223ms
tests/models-list.test.ts ✅ Passed 210ms
tests/responses-background-lifecycle.test.ts ✅ Passed 554ms
tests/responses-body-method-errors.test.ts ✅ Passed 330ms
tests/responses-cancel-timeout.test.ts ✅ Passed 239ms
tests/responses-cancel.test.ts ✅ Passed 280ms
tests/responses-compact-retries.test.ts ✅ Passed 377ms
tests/responses-compact.test.ts ✅ Passed 204ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 136ms
tests/responses-create-advanced.test.ts ✅ Passed 243ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.211s
tests/responses-create-errors.test.ts ✅ Passed 207ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 233ms
tests/responses-create-retries.test.ts ✅ Passed 270ms
tests/responses-create-stream-failures.test.ts ✅ Passed 843ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 213ms
tests/responses-create-stream-wire.test.ts ✅ Passed 3.435s
tests/responses-create-stream.test.ts ✅ Passed 94ms
tests/responses-create-terminal-states.test.ts ✅ Passed 257ms
tests/responses-create-timeout.test.ts ✅ Passed 212ms
tests/responses-create.test.ts ✅ Passed 217ms
tests/responses-delete.test.ts ✅ Passed 221ms
tests/responses-input-items-errors.test.ts ✅ Passed 589ms
tests/responses-input-items-list.test.ts ✅ Passed 352ms
tests/responses-input-items-options.test.ts ✅ Passed 336ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 267ms
tests/responses-input-tokens-count.test.ts ✅ Passed 218ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.4s
tests/responses-not-found-errors.test.ts ✅ Passed 253ms
tests/responses-parse.test.ts ✅ Passed 320ms
tests/responses-retrieve-retries.test.ts ✅ Passed 296ms
tests/responses-retrieve.test.ts ✅ Passed 234ms
tests/responses-stored-method-errors.test.ts ✅ Passed 593ms
tests/retry-behavior.test.ts ✅ Passed 3.117s
tests/sdk-error-shape.test.ts ✅ Passed 268ms

View OkTest run #35887369511

SDK merge (eeb186f77e92) · head (e75acdf3a4a7) · base (be9d66628ad7) · OkTest (a0be4375e02d)

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

47 mixed files remain; 0 existing customizations changed.

Compared be9d66628ad7 → e75acdf3a4a7. Generated baselines verified.

47 existing customizations unchanged
  • api.md
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py
  • src/openai/init.py
  • src/openai/_client.py
  • src/openai/resources/audio/transcriptions.py
  • src/openai/resources/audio/translations.py
  • src/openai/resources/beta/agents/sessions/sessions.py
  • src/openai/resources/beta/beta.py
  • src/openai/resources/beta/responses/responses.py
  • src/openai/resources/beta/threads/runs/runs.py
  • src/openai/resources/beta/threads/threads.py
  • src/openai/resources/chat/completions/completions.py
  • src/openai/resources/embeddings.py
  • src/openai/resources/files.py
  • src/openai/resources/live/forks.py
  • src/openai/resources/live/live.py
  • src/openai/resources/live/sideband.py
  • src/openai/resources/realtime/api.md
  • src/openai/resources/realtime/realtime.py
  • src/openai/resources/responses/responses.py
  • src/openai/resources/uploads/uploads.py
  • src/openai/resources/vector_stores/file_batches.py
  • src/openai/resources/vector_stores/files.py
  • src/openai/resources/videos.py
  • src/openai/resources/webhooks/init.py
  • src/openai/resources/webhooks/webhooks.py
  • src/openai/types/beta/agent_session_message.py
  • src/openai/types/chat/init.py
  • src/openai/types/chat/chat_completion_message_tool_call.py
  • src/openai/types/fine_tuning/fine_tuning_job_integration.py
  • src/openai/types/realtime/conversation_item_input_audio_transcription_delta_event.py
  • src/openai/types/realtime/realtime_error_event.py
  • src/openai/types/responses/init.py
  • src/openai/types/responses/response.py
  • src/openai/types/responses/response_function_web_search.py
  • src/openai/types/responses/response_function_web_search_param.py
  • src/openai/types/responses/responses_client_event.py
  • src/openai/types/responses/responses_client_event_param.py

7 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35887702627 --repo openai/openai-python \
  --name castiron-custom-code-35887702627-1 --dir /tmp/castiron-custom-code-35887702627-1
git apply --stat /tmp/castiron-custom-code-35887702627-1/custom-code.patch
cat /tmp/castiron-custom-code-35887702627-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin be9d66628ad7377bd36fe5a76ae6d735843f0e76 e75acdf3a4a7d2236f5e4f6a54d9d9d354d85c37
python3 scripts/castiron/custom_code_report.py report \
  --base be9d66628ad7377bd36fe5a76ae6d735843f0e76 \
  --head e75acdf3a4a7d2236f5e4f6a54d9d9d354d85c37 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-e75acdf3a4a7
cat /tmp/castiron-custom-code-e75acdf3a4a7/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed e75acdf. The README and contribution guide consistently direct community contributions to issues, limit pull requests to collaborators, and preserve private security reporting and the existing development instructions. The PR template also removes the conflicting invitation to external pull requests. No actionable findings.

Validation: immutable documentation diff, link-target and repository-guidance inspection; exact-head hosted checks are successful or intentionally skipped. No tests or builds run locally.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit ead1fa2 Sep 23, 2026
28 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/contribution-policy-20260923-openai-python branch September 23, 2026 16:50
@openai-sdks openai-sdks Bot mentioned this pull request Sep 23, 2026
pull Bot pushed a commit to Mattlk13/openai-python that referenced this pull request Sep 23, 2026
Automated Release PR
---


##
[3.19.1](openai/openai-python@v3.19.0...v3.19.1)
(2026-09-23)


### Bug Fixes

* **chat:** preserve single-pass tool iterables
([openai#3770](openai#3770))
([33ffa1f](openai@33ffa1f))
* **client:** merge HTTP headers case-insensitively
([openai#3486](openai#3486))
([5e39766](openai@5e39766))


### Chores

* **api:** clarify Chat Completions seed limits
([openai#3945](openai#3945))
([be9d666](openai@be9d666))


### Documentation

* clarify collaborator-only pull request policy
([openai#3948](openai#3948))
([ead1fa2](openai@ead1fa2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants