fix: preserve single files for fallback extraction paths - #3875
Merged
marcuswood-oai merged 3 commits intoSep 23, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Thanks for catching this and putting together the fix! We’ve merged main into your branch and simplified the tests. Single-file and list uploads are working in both clients, and our checks are passing—happy to get this in! |
marcuswood-oai
enabled auto-merge
September 23, 2026 18:35
Contributor
Castiron custom code✅ No new custom-code files detected. 47 mixed files remain; 0 existing customizations changed. Compared 47 existing customizations unchanged
7 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35922262769 --repo openai/openai-python \
--name castiron-custom-code-35922262769-1 --dir /tmp/castiron-custom-code-35922262769-1
git apply --stat /tmp/castiron-custom-code-35922262769-1/custom-code.patch
cat /tmp/castiron-custom-code-35922262769-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 4d1274681db7f34f671ff9e71adc1461d22a927b 9887eede6629afb385e7c8dd66fb5eb155520c73
python3 scripts/castiron/custom_code_report.py report \
--base 4d1274681db7f34f671ff9e71adc1461d22a927b \
--head 9887eede6629afb385e7c8dd66fb5eb155520c73 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-9887eede6629
cat /tmp/castiron-custom-code-9887eede6629/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
marcuswood-oai
approved these changes
Sep 23, 2026
Merged
pull Bot
pushed a commit
to specialized806/openai-python
that referenced
this pull request
Sep 24, 2026
Automated Release PR --- ## [3.19.2](openai/openai-python@v3.19.1...v3.19.2) (2026-09-23) ### Bug Fixes * preserve single files for fallback extraction paths ([openai#3875](openai#3875)) ([bfd3680](openai@bfd3680)) ### Chores * **api:** clarify approximate web search location defaults ([openai#3953](openai#3953)) ([a95c95e](openai@a95c95e)) * **api:** clarify Realtime modality array definitions ([openai#3954](openai#3954)) ([e79cf53](openai@e79cf53)) * **api:** correct fine-tuning bounds and Realtime response reference ([openai#3949](openai#3949)) ([325a948](openai@325a948)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
Fixes #3874.
When the Skills
filesparameter is a single file, the array extraction path consumes it before the fallback single-file path can run. This produces an empty JSON request instead of uploading the file.Keep non-list values available when a path still expects an array. Direct file extraction and list uploads retain their existing behavior. Add bytes/tuple extraction regressions and synchronous/asynchronous public-client tests that construct a real in-memory zip and inspect its multipart field, filename and content through MockTransport.
Additional context & links
PYTHONPATH=src .venv/bin/python -m pytest -o addopts='' tests/test_extract_files.py tests/test_files.py -q. Tests run serially and make no live API requests.git diff --checkpasses.