Repository navigation
fix(tests): make the test suite pass on a default Windows checkout - #3634
Open
MohammedAlkindi wants to merge 3 commits into
Open
MohammedAlkindi wants to merge 3 commits into
MohammedAlkindi wants to merge 3 commits into
Conversation
tests/sample_file.txt is asserted on byte-for-byte by the base64 transform tests, but with core.autocrlf (the Git for Windows default) a fresh clone rewrites it to CRLF and both test_base64_file_input variants fail. Mark the fixture -text so every platform checks out the exact committed bytes.
test_proxy_environment_variables set HTTPS_PROXY first and then deleted
the lowercase variants as cleanup. os.environ is case-insensitive on
Windows, so delenv("https_proxy") also removed the HTTPS_PROXY that was
just set, the client saw no proxy in the environment, and the mounts
assertion failed. Do the cleanup first and set the variable afterwards.
Contributor
Castiron custom code✅ No new custom-code files detected. 34 mixed files remain; 0 existing customizations changed. Compared 34 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36284037941 --repo openai/openai-python \
--name castiron-custom-code-36284037941-1 --dir /tmp/castiron-custom-code-36284037941-1
git apply --stat /tmp/castiron-custom-code-36284037941-1/custom-code.patch
cat /tmp/castiron-custom-code-36284037941-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9917c6e28e66e90e1227b3d223c06a8c5441515a 887a261ed6a66b81e4dc08a481683a3adf2cb541
python3 scripts/castiron/custom_code_report.py report \
--base 9917c6e28e66e90e1227b3d223c06a8c5441515a \
--head 887a261ed6a66b81e4dc08a481683a3adf2cb541 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-887a261ed6a6
cat /tmp/castiron-custom-code-887a261ed6a6/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
On a fresh Windows clone with default Git settings, four tests fail before any change:
test_base64_file_inputasserts the exact bytes oftests/sample_file.txt, butcore.autocrlf=truechecks it out as CRLF. A new.gitattributesmarks that one file-text; the committed blob is already LF.test_proxy_environment_variablessetsHTTPS_PROXYand then deletes the lowercase variants.os.environis case-insensitive on Windows, so the delete also removesHTTPS_PROXYand the client sees no proxy. The cleanup now runs beforesetenv; on POSIX the order makes no difference.After both changes the four tests pass, and
tests/test_client.pyplustests/test_transform.pygive254 passed, 2 skipped.Additional context & links
No generated file is touched:
tests/test_client.pyhas no Castiron generated-file banner and.gitattributesis new. Seen on Windows 11 with git 2.53.0.windows.2 and Python 3.12.10.