Skip to content

Fix #315: Support openai api --json completions.create ... - #3624

Closed
vikasvardhanv wants to merge 1 commit into
openai:mainfrom
vikasvardhanv:fix-issue-315
Closed

vikasvardhanv wants to merge 1 commit into
openai:mainfrom
vikasvardhanv:fix-issue-315

Conversation

@vikasvardhanv

Copy link
Copy Markdown

Fix #315: Support openai api --json completions.create ...

(No detailed fix description was generated — see the diff below for the actual change.)

@vikasvardhanv
vikasvardhanv requested a review from a team as a code owner August 16, 2026 01:17

Copy link
Copy Markdown
Contributor

Thanks for contributing! I reviewed the diff: making CompletionChoice.finish_reason optional doesn’t add the CLI JSON output requested in #315. The CLI bundled with openai-python was removed in v2.35.0, and the separate official OpenAI CLI supports full responses with --format json. Closing this PR alongside #315; no change to the generated field is needed for that request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support openai api --json completions.create ...

2 participants