Repository navigation
fix(examples): split push-to-talk shebang arguments - #3210
Conversation
|
Good portability cleanup. |
317260c to
e67afa8
Compare
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
One same-class executable shebang is still missing from this portability sweep: examples/realtime/push_to_talk_app.py:1 remains #!/usr/bin/env uv run (mode 100755). On Linux, the kernel passes uv run as one argument and GNU env tries to find an executable with that literal name, so direct invocation fails with the same error these four edits fix. Please change it to #!/usr/bin/env -S uv run as well. The four modified Rye shebangs, executable modes, Ruff/format checks, and compile validation are otherwise clean.
Five executable examples use an env shebang without the -S flag: examples/audio.py examples/speech_to_text.py examples/text_to_speech.py examples/realtime/realtime.py examples/realtime/push_to_talk_app.py CONTRIBUTING.md shows the canonical form as #!/usr/bin/env -S rye run python. Without -S the kernel passes the whole interpreter string to env as one argument, so env looks for a program named 'rye run python' and the script fails. This affects GNU env as well as BSD env. The first four use the rye shebang; push_to_talk_app.py has the same defect with 'uv run'. Only shebang lines change; executable modes are unchanged.
dd7db2c to
ae028fc
Compare
|
added |
marcuswood-oai
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 43 mixed files remain; 0 existing customizations changed. Compared 43 existing customizations unchanged
3 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35005432454 --repo openai/openai-python \
--name castiron-custom-code-35005432454-1 --dir /tmp/castiron-custom-code-35005432454-1
git apply --stat /tmp/castiron-custom-code-35005432454-1/custom-code.patch
cat /tmp/castiron-custom-code-35005432454-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 1493321affb1814fba7b669892e376a119d8d36f 7b74cd88caa0219b3ccc82cf011521d4d034931a
python3 scripts/castiron/custom_code_report.py report \
--base 1493321affb1814fba7b669892e376a119d8d36f \
--head 7b74cd88caa0219b3ccc82cf011521d4d034931a --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7b74cd88caa0
cat /tmp/castiron-custom-code-7b74cd88caa0/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
|
Thanks for fixing this. The push-to-talk example still passes |
Thanks for fixing this. The push-to-talk example still passes uv run as a single executable name when launched directly. Adding -S fixes the argument splitting and matches uv’s documented shebang usage.
Automated Release PR --- ## [3.14.1](openai/openai-python@v3.14.0...v3.14.1) (2026-09-15) ### Bug Fixes * **client:** validate retry limits and preserve application errors ([openai#3867](openai#3867)) ([f86c721](openai@f86c721)) * correct typo "th" to "the" in StreamAlreadyConsumed error message ([openai#3022](openai#3022)) ([7186203](openai@7186203)) * **examples:** correct Azure endpoint hostname ([openai#3298](openai#3298)) ([543516c](openai@543516c)) * **examples:** refresh chat streaming examples ([openai#2974](openai#2974)) ([54f460e](openai@54f460e)) * **examples:** split push-to-talk shebang arguments ([openai#3210](openai#3210)) ([d241ed6](openai@d241ed6)) * **examples:** use uv in remaining Python launchers ([openai#3821](openai#3821)) ([8c76c4f](openai@8c76c4f)) * log only metadata for Live WebSocket diagnostics ([openai#3865](openai#3865)) ([ccc10f5](openai@ccc10f5)) * **responses:** skip structured parsing for commentary ([openai#3861](openai#3861)) ([6520df1](openai@6520df1)) ### Chores * **examples:** bump module_client.py to gpt-5.6 ([openai#3211](openai#3211)) ([1493321](openai@1493321)) * remove unused fine-tuning data validators ([openai#3863](openai#3863)) ([9640f29](openai@9640f29)) ### Documentation * clarify async client cleanup ([openai#2388](openai#2388)) ([a3d83b5](openai@a3d83b5)) * clarify filenames for in-memory file uploads ([openai#3729](openai#3729)) ([cb27380](openai@cb27380)) * **client:** correct retry jitter comment ([openai#2252](openai#2252)) ([bdbbc16](openai@bdbbc16)) * fix Realtime docstring wording ([openai#3535](openai#3535)) ([8cb9ded](openai@8cb9ded)) * fix reusing wording in Azure client docstrings ([openai#3061](openai#3061)) ([dc625f9](openai@dc625f9)) * fix streaming comment typo ([openai#3005](openai#3005)) ([d421d7a](openai@d421d7a)) * fix vector store polling helper paths ([openai#3101](openai#3101)) ([2ef2de6](openai@2ef2de6)) * **readme:** correct SSE terminology ([openai#2837](openai#2837)) ([caaa9b4](openai@caaa9b4)) * update Responses API reference link ([openai#3279](openai#3279)) ([557bd06](openai@557bd06)) * **utils:** correct query component RFC reference ([openai#3300](openai#3300)) ([929a8a5](openai@929a8a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
4 participants
five executable examples use an env shebang without
-S:added
push_to_talk_app.pyper your review. i checked every mode-100755 file underexamples/and those five are the only ones missing-S. (azure.py,azure_ad.pyandmodule_client.pyare 755 with no shebang at all — different issue, left alone.)also correcting myself: i said linux env splits the args so this only broke on older BSD. that's wrong, it fails there too — on coreutils 9.4
./examples/audio.pygivesenv: 'rye run python': No such file or directory.only shebang lines change. modes unchanged, ruff check + format clean on all five.