feat(beta): expose typed application actions as agent tools - #1127
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
Security findingsAdvisory findings (1)
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OkTest Summary❌ Failed for Java SDK PR #1127. SDK merge (pending) · head ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeb8c439ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Castiron custom code✅ No new custom-code files detected. 93 mixed files remain; 0 existing customizations changed. Compared 93 existing customizations unchanged
53 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36791059323 --repo openai/openai-java \
--name castiron-custom-code-36791059323-1 --dir /tmp/castiron-custom-code-36791059323-1
git apply --stat /tmp/castiron-custom-code-36791059323-1/custom-code.patch
cat /tmp/castiron-custom-code-36791059323-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 4ae27f8b63192ef6c5c2d4103cdba7395a06f3f7 e53294cd7b936b20b29d44cc2ee58131ba10b305
python3 scripts/castiron/custom_code_report.py report \
--base 4ae27f8b63192ef6c5c2d4103cdba7395a06f3f7 \
--head e53294cd7b936b20b29d44cc2ee58131ba10b305 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-e53294cd7b93
cat /tmp/castiron-custom-code-e53294cd7b93/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 799eee090e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review pls |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🛡️ Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 8b9bfb7cad
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Summary
Expose an application's typed action as a beta Agent tool without maintaining its JSON schema, registration name, and argument conversion separately.
Before:
After:
com.openai.helpers.beta.agents.AgentFunctionToolreuses the SDK's class-based schema and Jackson conventions, including@JsonTypeNameand@JsonClassDescription.ofAsyncbinds completion-stage callbacks toasyncToolHandler. Both use the existing stream dispatcher and can accompany raw handlers on an existing session.Includes a short usage guide and a read-only catalog lookup example; application dependencies stay in the bound method.