Repository navigation
docs(cli): keep Homebrew picker setup on first run - #367
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 6 mixed files remain; 0 existing customizations changed. Compared 6 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37183595344 --repo openai/openai-cli \
--name castiron-custom-code-37183595344-1 --dir /tmp/castiron-custom-code-37183595344-1
git apply --stat /tmp/castiron-custom-code-37183595344-1/custom-code.patch
cat /tmp/castiron-custom-code-37183595344-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin bae10ccb79bde2bacb142c387e7b31539913313a d9af20344e10e09cd77d93a656cd0586059dee15
python3 scripts/castiron/custom_code_report.py report \
--base bae10ccb79bde2bacb142c387e7b31539913313a \
--head d9af20344e10e09cd77d93a656cd0586059dee15 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-d9af20344e10
cat /tmp/castiron-custom-code-d9af20344e10/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2a094d013
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7597c4062c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
saioai
changed the title
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed d9af203. No blocking findings. The docs correctly describe first-run setup and its existing eligibility and opt-out rules. The release test checks the real YAML for pre/post cask hooks, alongside the existing artifact checks. The change stays small and fits the current design.
I reviewed all three changed files, surrounding setup code, and earlier review replies. Hosted checks pass for this head. I did not rerun local tests, GoReleaser generation, or a native Homebrew installation.
Automated Release PR --- ## [1.37.0](openai/openai-cli@v1.36.0...v1.37.0) (2026-10-04) ### Features * **cli:** include fish picker shortcuts in Linux packages ([openai#361](openai#361)) ([bae10cc](openai@bae10cc)) ### Documentation * **cli:** keep Homebrew picker setup on first run ([openai#367](openai#367)) ([fbe7e46](openai@fbe7e46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
…openai#438) Existing image compatibility checks still expected cleared prompts and one Kitty frame per image. This updates those checks for retained drafts and chunked image output. ### What changes - Check retained prompts after generation, printing, cancellation, and reopening. - Keep legacy draft migration, exact requests, saved bytes, and terminal cleanup assertions. - Check authentication recovery without automatically retrying generation. - Reassemble Kitty chunks before checking image counts and pixels. - Reject incomplete frames, invalid chunk sizes, malformed headers, and invalid base64. - Preserve separate capture files for case names containing periods. - Require exact shell-setup receipts on stderr while keeping stdout empty. ### Commands No CLI commands or flags change. Existing checks use synthetic local responses and temporary settings. ```sh python3 -I -B -m unittest discover -s scripts -p test_terminal_images.py python3 -I -B scripts/check-image-picker-integration.py /path/to/openai /tmp/image-integration python3 -I -B scripts/check-image-picker-reuse.py /path/to/openai /tmp/image-reuse python3 -I -B scripts/check-image-picker-native.py /path/to/openai /tmp/image-protocol ``` ### Code The existing scripts share Kitty parsing and picker synchronization helpers. Runtime packages, generated commands, dependencies, and startup wiring stay unchanged. ### Tested macOS ARM64, Go 1.26.9: 413 focused test and subtest results passed. These cover partial saves, cancellation, large images, model discovery, preferences, loading, snapshots, and font capacity. The corrected checkers passed 162 synthetic process and PTY cases. The old checkers failed on retained drafts and valid Kitty chunks from the same main binary. The corrected parser accepted all 12 captured protocol cases and passed 35 independent adversarial probes. Two Python unit tests passed. Two additional CLI sessions verified separate capture files for dotted case names. Temporary-profile setup passed in Bash 3.2 and zsh. Fish was unavailable. Bash 3.2 used ordinary-completion fallback; zsh registered its picker hook. Independent review, CI, and automated code and security reviews passed at `b8c0d09`. CI includes native setup checks on macOS and Windows, with skipped cases recorded separately. Native Windows, Linux, WSL, SSH/tmux, and named graphical-terminal coverage remain incomplete. Private PTYs establish process and protocol behavior, not native graphical appearance. ### Demo No product appearance changes. This PR repairs synthetic compatibility checks, so it does not add a visual demo. <!-- compatibility-parent: openai#277 --> <!-- compatibility-parent: openai#291 --> <!-- compatibility-parent: openai#293 --> <!-- compatibility-parent: openai#294 --> <!-- compatibility-parent: openai#296 --> <!-- compatibility-parent: openai#297 --> <!-- compatibility-parent: openai#302 --> <!-- compatibility-parent: openai#318 --> <!-- compatibility-parent: openai#325 --> <!-- compatibility-parent: openai#342 --> <!-- compatibility-parent: openai#357 --> <!-- compatibility-parent: openai#358 --> <!-- compatibility-parent: openai#359 --> <!-- compatibility-parent: openai#360 --> <!-- compatibility-parent: openai#361 --> <!-- compatibility-parent: openai#367 --> <!-- compatibility-parent: openai#368 --> <!-- compatibility-parent: openai#369 --> <!-- compatibility-parent: openai#370 --> <!-- compatibility-parent: openai#377 --> <!-- compatibility-parent: openai#381 --> <!-- compatibility-parent: openai#383 --> <!-- compatibility-parent: openai#394 --> <!-- codex-thread: 01a131fd-9aab-7e73-8988-52a0bbd0412d -->
Homebrew users already receive picker shortcuts through first-run or explicit setup. This documents that behavior and guards against adding cask setup hooks, which would introduce an extra profile-writing lifecycle.
What changes
openairun, with existing opt-outs and explicit setup available.Commands
No new commands or flags. After installation, run
openaiin an eligible interactive shell, then open a new terminal to load the shortcut. Automatic zsh setup still requires an exported absoluteZDOTDIR; explicit setup remains available.Code
Only documentation and the existing release configuration test change relative to main. The release configuration, runtime, dependencies, and workflows match main.
Tested
On macOS arm64, 41 first-run and 16 public setup/help process checks passed without skips. The release guard passes and rejects the previous hook configuration. Independent adversarial review found no remaining issue.
Verified GoReleaser 2.15.4 generated synthetic macOS archives and a cask with the existing binary, completions, and manual. Homebrew 7.0.1 loaded it without warnings in normal and strict/developer modes; the previous cask failed the strict check. No actual Homebrew installation or user profile edits were performed. Codex code review reported no major issues and security review found no issues on the current head. CI passed on
d9af203: 20 successful checks, three administrative skips, and both Castiron statuses passed.Demo
No visible behavior change relative to main. Existing first-run setup is preserved; this PR adds documentation and a regression guard, so no new UI demo is needed.