feat(images): open the picker with Tab in supported shells

[saioai]

The image picker currently opens when you press Enter after openai images generate. This adds an optional Tab shortcut for Bash, zsh and fish, while keeping ordinary command and file completion.

What changes

• Open the picker with Tab on the complete bare image-generation command; Ctrl+C returns to the editable shell line.
• Preserve existing completion, custom bindings and later binding replacements. openai_picker_disable turns the shortcut off in the current session.
• Keep normal Tab completion in PowerShell and Bash before 4.3; Enter opens the picker.
• Keep ordinary Bash completion compatible with Bash 3.2 and preserve the caller's file variable. Other commands retain normal Tab-key completion behavior.
• Support Bash emacs and vi modes, including re-enabling after a temporary custom Tab binding.

Commands

The existing @completion command gains an explicit --picker option:

source <(openai @completion bash --picker) # Bash 4.3+

source <(openai @completion zsh --picker) # After compinit

openai @completion fish --picker | source

Scripts without --picker retain ordinary completion. The opt-in affects only the current shell and writes no startup files. Shortcut guide.

Code

Builds on #357, now merged into main. This remains independent of #358 (remembered settings). internal/autocomplete owns script rendering and shell hooks. The existing pkg/custom configurator adds the flag and fixed PowerShell guidance. Main, generated commands and dependencies are unchanged.

Tested

The Bash review fixes pass 171 autocomplete test/subtest results under the race detector and five public completion results, without skips on macOS arm64. New native Bash regressions cover key-sensitive completion for another command and disable/restore/re-enable in both emacs and vi modes. Both reported issues reproduce on the previous code. Build, focused vet and the trusted main custom-code budget check pass (435/1,000).

An independent reviewer passed 18 workflows using the emitted script and real Bash line editors, including repeated completion, replaced/private bindings, re-enabling and actual picker cancellation. The earlier merged-core checks passed 63 public CLI/native-shell, 75 picker race and 50 synthetic PTY/process results; their core code is unchanged by this two-file fix.

Hosted CI passed on the previous commit and will rerun for this update. Native Windows/Linux picker execution and the full platform campaign remain deferred.

Demo

macOS arm64 native zsh PTY replay, core 8fefbb8 to Tab candidate 238bc32. Before, Tab leaves the bare command in the shell; after enabling the shortcut, Tab opens the picker. No API request or real profile changes. The later module-classification fix and main update preserve this recorded Tab workflow; the new candidate was checked with fresh native-shell runs.

Before:

After:

Recording recipe and original captures. Native shortcut regression checks.

[github-actions]

Castiron custom code

Evaluated main: 58edd84760a48b91d75e58afd0b6da056d95fbcd.

✅ No new custom-code files detected.

6 mixed files remain; 0 existing customizations changed.

Compared 100628d84900 → 8f1358463f00. Generated baselines verified.

6 existing customizations unchanged

• pkg/cmd/adminorganizationcertificate.go
• pkg/cmd/audiovoice.go
• pkg/cmd/image.go
• scripts/castiron/README.md
• scripts/castiron/custom_code_report.py
• scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 37096471911 --repo openai/openai-cli \
  --name castiron-custom-code-37096471911-1 --dir /tmp/castiron-custom-code-37096471911-1
git apply --stat /tmp/castiron-custom-code-37096471911-1/custom-code.patch
cat /tmp/castiron-custom-code-37096471911-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 58edd84760a48b91d75e58afd0b6da056d95fbcd 8f1358463f00becdf37928ca4e723be864a289c6
python3 scripts/castiron/custom_code_report.py report \
  --base 58edd84760a48b91d75e58afd0b6da056d95fbcd \
  --head 8f1358463f00becdf37928ca4e723be864a289c6 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-8f1358463f00
cat /tmp/castiron-custom-code-8f1358463f00/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-03T04:27:48.830154Z	8f13584	New commits
🔒 Security Review	✅ Completed 2026-10-03T04:28:57.892507Z	8f13584	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[markstuart-oai]

Reviewed 6173092 against main 100628d. Two Bash issues remain. The Tab macro changes the key seen by other completion functions. A stale binding marker can also prevent re-enabling the picker. Details are inline.

Hosted CI is green on this commit. These findings come from source inspection; I did not run the shell tests locally.