Skip to content

fix(cli): preserve complete plain-text audio responses - #212

Open
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-86
Open

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-86

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Preserves complete text, SRT, and VTT responses from audio transcription and translation commands.

Changes

  • Uses response content type to preserve plaintext even when the transcript resembles JSON.
  • Keeps complete transcript and subtitle bodies, including Unicode and line breaks, through the existing output modes.

Castiron-Internal-PR: openai/openai-cli-internal#86
Castiron-Source-SHA: 9c2eb49628fd9cf3d3b96d5e3e123b24a1fd67c9
Castiron-Public-Base-SHA: 0169bff
@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

Castiron custom code

Mixed files: 5 → 8

3 newly customized · 0 customizations removed · 0 existing customizations changed · 1 generated baselines changed

Compared 0169bff050ff00b505de61f1. Generated baselines verified.

File Result Current custom patch
pkg/cmd/audiotranscription.go Newly customized +8 / −1
pkg/cmd/audiotranslation.go Newly customized +8 / −1
pkg/cmd/image.go Generated baseline changed +1 / −1
5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/cmd.go
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35553125602 --repo openai/openai-cli \
  --name castiron-custom-code-35553125602-1 --dir /tmp/castiron-custom-code-35553125602-1
git apply --stat /tmp/castiron-custom-code-35553125602-1/custom-code.patch
cat /tmp/castiron-custom-code-35553125602-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 0169bff050ff9c05c4609b669c06709306d464fa 00b505de61f19a45cdc81182726635b57892687b
python3 scripts/castiron/custom_code_report.py report \
  --base 0169bff050ff9c05c4609b669c06709306d464fa \
  --head 00b505de61f19a45cdc81182726635b57892687b --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-00b505de61f1
cat /tmp/castiron-custom-code-00b505de61f1/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 02:07
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 02:07
@markstuart-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-21T02:10:40.608731Z 00b505d Manual request
🔒 Security Review Completed 2026-09-21T02:12:27.566590Z 00b505d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 00b505de61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 00b505de61

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants