Skip to content

chore(api): document API error response contracts - #210

Open
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-87
Open

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-87

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Clarifies documented HTTP error responses while preserving existing CLI commands.

Changes

  • Describe verified failure statuses, error envelopes and applicable retry headers.
  • Keep the existing command surface and error behavior.

Source monorepo PRs: #1530657, #1530727, #1530744, #1530838, #1530911, #1530918, #1530926, #1530938, #1530960, #1530967.

@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

Castiron custom code

Mixed files: 5 → 6

1 newly customized · 0 customizations removed · 0 existing customizations changed · 1 generated baselines changed

Compared 0169bff050ff7b193c38172b. Generated baselines verified.

File Result Current custom patch
pkg/cmd/image.go Generated baseline changed +1 / −1
5 existing customizations unchanged
  • pkg/cmd/adminorganizationcertificate.go
  • pkg/cmd/cmd.go
  • scripts/castiron/README.md
  • scripts/castiron/custom_code_report.py
  • scripts/castiron/test_custom_code_report.py

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35530559718 --repo openai/openai-cli \
  --name castiron-custom-code-35530559718-1 --dir /tmp/castiron-custom-code-35530559718-1
git apply --stat /tmp/castiron-custom-code-35530559718-1/custom-code.patch
cat /tmp/castiron-custom-code-35530559718-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 0169bff050ff9c05c4609b669c06709306d464fa 7b193c38172bd674be53d7cf1a1c9a8f1dc47aee
python3 scripts/castiron/custom_code_report.py report \
  --base 0169bff050ff9c05c4609b669c06709306d464fa \
  --head 7b193c38172bd674be53d7cf1a1c9a8f1dc47aee --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-7b193c38172b
cat /tmp/castiron-custom-code-7b193c38172b/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 20, 2026 17:44
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 20, 2026 17:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-20T18:56:38.652225Z 7b193c3 New commits
🔒 Security Review Completed 2026-09-20T18:57:14.367151Z 7b193c3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Castiron-Internal-PR: openai/openai-cli-internal#87
Castiron-Source-SHA: f0499d1e6ed09bd464d59d52f6ce20d09b524522
Castiron-Public-Base-SHA: 0169bff
@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-87 branch from 35ded36 to 7b193c3 Compare September 20, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants