fix(completion): hide internal commands and suppress fish debug logs - #21
jeet-dekivadia wants to merge 2 commits into
Conversation
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
Signed-off-by: Jeet Dekivadia <jeet.university@gmail.com>
|
Small follow-up for review context. This patch is limited to completion behavior: hidden commands stay hidden at the shell-completion boundary, and the fish probe no longer writes debug noise to |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
saioai
left a comment
There was a problem hiding this comment.
please resolve the conflicts against main and keep the remaining hidden-command fix. the fish logging change already shipped, so please preserve the newer completion code and tests.
Summary
/tmp/fish-debug.logWhy
The non-empty completion path already skips
child.Hidden, but the initial empty-input branch did not. An initial tab press could therefore expose internal commands such as__complete,@completion, and@manpages.The fish completion script also appended diagnostics from every tab-completion invocation to a fixed temporary file. Bash already suppresses the same internal probe's stderr. Applying the same behavior in fish avoids an unbounded cross-session debug log during normal CLI use.
Validation
git diff --checkgo test ./internal/autocomplete -count=1Remote Linux validation
git diff --check./scripts/bootstrap./scripts/lint./scripts/test