Conversation
Castiron custom codeMixed files: 5 → 6 1 newly customized · 0 customizations removed · 0 existing customizations changed · 0 generated baselines changed Compared
5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35397157585 --repo openai/openai-cli \
--name castiron-custom-code-35397157585-1 --dir /tmp/castiron-custom-code-35397157585-1
git apply --stat /tmp/castiron-custom-code-35397157585-1/custom-code.patch
cat /tmp/castiron-custom-code-35397157585-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 1d4e76cb3cbed9992fc6a8b73e50249d2033e575 2f06e498edb324b0ba5f7d66e319e91e866b318b
python3 scripts/castiron/custom_code_report.py report \
--base 1d4e76cb3cbed9992fc6a8b73e50249d2033e575 \
--head 2f06e498edb324b0ba5f7d66e319e91e866b318b --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-2f06e498edb3
cat /tmp/castiron-custom-code-2f06e498edb3/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft for review
This is a reviewable snapshot of the image UX work so far, including the saved inline-image baseline and the subsequent onboarding, help, model discovery, naming, and streaming work. It is a draft for feedback, not a release-ready claim of universal terminal support.
What changes for a user
openaishows a short starting guide;help setupexplains credentials, short image help gives a runnable example, andhelp --allpreserves the full flag reference.gpt-image-2.5-sunburst, one PNG, and automatic size/quality/background/moderation. Plain-language guides explain the exact flags and values, including counts from 1 to 10.~/Downloads/gpt-images/, prints saved paths, and derives filenames from the prompt. Existing files are retained. Explicit API formats and scripting paths remain available.images modelschecks a maintained list of exact image model IDs with bounded per-model requests;--offlineneeds no key. It keeps partial results on timeouts and distinguishes visibility from generation permission.--modelwas already optional; this changes the default in the saving workflow rather than introducing optional model selection. Readable final output and automatic downloads apply to generation; existing editing and variation commands retain their API-output behavior.Start the code review here
cmd/openai/main.go→pkg/cmd/image.go→pkg/cmd/image_output.go→internal/imageoutput/for the main generation path.pkg/cmd/image_stream.gofor progress events;help.go,image_help.go,image_options.go, andimage_models.gofor the user-facing guides.pkg/cmd/image_inline_preserved.go,internal/imagefont/,internal/imagefontmac/, andinternal/imagegallery/for the Apple Terminal experiment.The generated image handler uses small integration hooks into handwritten helpers. The dependency addition is
golang.org/x/image v0.44.0. This snapshot contains source, tests, and docs; local executables, generated fonts, preview caches, user images, credentials, and private workspace notes are excluded.Validation
imagefont,imagefontmac,imagegallery,imageoutput,imagepreview,imageopen,imageprefs, andimagemodels.cmd/openaiandpkg/cmdtests with-run '^Test(Main|Help|Image[A-Z]|ImagesGenerate(Output|FriendlyStream)|ReportImagePreview)' -count=1.go mod verify,git diff --check, and builds for macOS arm64, Windows amd64, and Linux amd64.2f06e498edb324b0ba5f7d66e319e91e866b318b; policy base:1d4e76cb3cbed9992fc6a8b73e50249d2033e575. This counts customization of generated files, not the total size of this PR.Areas for mentor / maintainer feedback
Try the snapshot
The commands above need no API key and generate no images.
./openai help setupexplains how to configure a key before making a generation request.