fix: make yaml formatting side-effect free - #20
2830500285 wants to merge 1 commit into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
saioai
left a comment
There was a problem hiding this comment.
yaml output can fetch another page after reaching --max-items and fail unnecessarily. please rebase onto main, preserve its pagination limit fix, and add a regression test.
Summary
ShowJSON/ iterator callers responsible for writing output, so YAML can be buffered, counted, and paged consistentlyShowJSONYAML output pathNo linked issue; I found this while looking for another runtime correctness fix after the currently open issues were already covered by existing PRs.
Validation
go test ./pkg/cmd -run 'TestFormatJSON|TestShowJSONYAML|TestShowJSONIterator'go test ./... -run 'TestFormatJSON|TestShowJSONYAML|TestShowJSONIterator'go build ./...Note: I also attempted
go test ./...locally, but this Windows environment is missing/bin/bashfor the autocomplete tests and does not have the mock server running onlocalhost:4010for generated command tests.