chore(deps): bump golang.org/x/sys from 0.47.0 to 0.48.0 in the golang-x group across 1 directory - #187
chore(deps): bump golang.org/x/sys from 0.47.0 to 0.48.0 in the golang-x group across 1 directory#187dependabot[bot] wants to merge 1 commit into
Conversation
Castiron custom code✅ No new custom-code files detected. 5 mixed files remain; 0 existing customizations changed. Compared 5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 35518509627 --repo openai/openai-cli \
--name castiron-custom-code-35518509627-1 --dir /tmp/castiron-custom-code-35518509627-1
git apply --stat /tmp/castiron-custom-code-35518509627-1/custom-code.patch
cat /tmp/castiron-custom-code-35518509627-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 0169bff050ff9c05c4609b669c06709306d464fa bbca43b3c84270ff4d1a8027172058d4c6683aa1
python3 scripts/castiron/custom_code_report.py report \
--base 0169bff050ff9c05c4609b669c06709306d464fa \
--head bbca43b3c84270ff4d1a8027172058d4c6683aa1 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-bbca43b3c842
cat /tmp/castiron-custom-code-bbca43b3c842/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37c97caba5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| module github.com/openai/openai-cli | ||
|
|
||
| go 1.25.0 | ||
| go 1.26.0 |
There was a problem hiding this comment.
Align the configured toolchain with the new Go minimum
Raising the module directive to 1.26.0 conflicts with the repository's .go-version (1.25) and its documented Go 1.25 support. With the toolchain selected by the CI and publish workflows, GOTOOLCHAIN=local ./scripts/bootstrap now fails immediately; with the default auto mode, Go instead downloads exactly go1.26.0, bypassing the workflows' deliberate check-latest selection of a patched toolchain. Either retain a dependency compatible with Go 1.25 or update .go-version, the installation documentation, and the release-toolchain configuration together.
AGENTS.md reference: AGENTS.md:L15-L18
Useful? React with 👍 / 👎.
dc9e3f1 to
1860977
Compare
saioai
left a comment
There was a problem hiding this comment.
requesting changes: this bumps the minimum to go 1.26, but our toolchain and docs still say 1.25, and ci is failing on that mismatch. please update those together, or keep a compatible x/sys version for now.
ffc6035 to
7b300a9
Compare
Bumps the golang-x group with 1 update in the / directory: [golang.org/x/sys](https://github.com/golang/sys). Updates `golang.org/x/sys` from 0.47.0 to 0.48.0 - [Commits](golang/sys@v0.47.0...v0.48.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-version: 0.48.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
7b300a9 to
bbca43b
Compare
Bumps the golang-x group with 1 update in the / directory: golang.org/x/sys.
Updates
golang.org/x/sysfrom 0.47.0 to 0.48.0Commits
613e257cpu: add riscv64 hwprobe drift test6f7b10funix: add MLOCK_ONFAULT constant663e7c8cpu: add basic support for GOARCH=sparc64de5f12fcpu: add ppc64le POWER10 detection80e8acfunix: run go fix1e3c182unix: add IPMI interfaced429e20unix: stop generating sparc termbits from the generic headerbd3bddfunix: add missing HWTSTAMP_* constantse812f53windows: add SO_SNDTIMEO constant for socket optionsf6989c5unix: align Ifreq so its union accessors cannot fault