Skip to content

[sandboxing] Remove Darwin user cache write from Seatbelt network policy#21443

Open
evawong-oai wants to merge 1 commit intomainfrom
codex/narrow-darwin-user-cache-seatbelt
Open

[sandboxing] Remove Darwin user cache write from Seatbelt network policy#21443
evawong-oai wants to merge 1 commit intomainfrom
codex/narrow-darwin-user-cache-seatbelt

Conversation

@evawong-oai
Copy link
Copy Markdown
Contributor

@evawong-oai evawong-oai commented May 7, 2026

Summary

  1. Removes the broad DARWIN_USER_CACHE_DIR write rule from the macOS Seatbelt network policy.
  2. Removes the now unused policy parameter plumbing for that cache path.
  3. Adds sandboxing coverage that keeps com.apple.trustd.agent for TLS while rejecting the cache write rule.

Why

This closes the exact cache poisoning boundary. The earlier gh TLS issue is now covered by trustd access, so the cache write is no longer needed.

Validation

  1. Rust formatting passed.
  2. The sandboxing crate tests passed.
  3. Local macOS Seatbelt repro with patched policy passed. gh api returned 21442 without the cache write rule.

@evawong-oai evawong-oai marked this pull request as ready for review May 7, 2026 00:40
@viyatb-oai
Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants