Skip to content

[codex] Parallelize skills list cwd loading#21441

Merged
xli-oai merged 2 commits intomainfrom
xli-codex/parallel-skills-list-cwds
May 7, 2026
Merged

[codex] Parallelize skills list cwd loading#21441
xli-oai merged 2 commits intomainfrom
xli-codex/parallel-skills-list-cwds

Conversation

@xli-oai
Copy link
Copy Markdown
Contributor

@xli-oai xli-oai commented May 6, 2026

Summary

  • process skills/list cwd entries with bounded concurrency of 5
  • preserve the caller's requested cwd order in the response
  • add coverage that verifies response ordering remains stable

Why

Cold-start desktop traces showed that skills/list can dominate the shared config queue when it scans many workspace roots serially. The expensive work is largely independent per cwd, so the request was paying the sum of all cwd costs instead of the cost of the slowest bounded batch.

Impact

This keeps current request semantics intact while reducing the wall-clock time of large multi-root skills/list calls. That should also reduce how long later config-family requests, such as plugin/list, wait behind skills/list during startup.

Validation

  • just fmt
  • cargo test -p codex-app-server
  • cargo test -p codex-app-server skills_list_preserves_requested_cwd_order

@xli-oai xli-oai added the oai PRs contributed by OpenAI employees label May 6, 2026 — with ChatGPT Codex Connector
@xli-oai xli-oai marked this pull request as ready for review May 7, 2026 00:39
@xli-oai
Copy link
Copy Markdown
Contributor Author

xli-oai commented May 7, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. What shall we delve into next?

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@xli-oai xli-oai merged commit 5bc33fe into main May 7, 2026
26 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

oai PRs contributed by OpenAI employees

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants