[codex] Add codex-api client factory#21437
Closed
pakrym-oai wants to merge 1 commit intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
codex-corecreates several codex-api REST clients from the same provider/auth setup, but each call site constructed the concrete client directly. This makes it harder to add shared client creation behavior without touching every client type or turningModelClientinto the owner of unrelated services.What changed
ApiClientFactoryplus anApiClienttrait implemented directly on the codex-api client types used by core.SessionServices, built from the same shared model provider asModelClient.ModelClientfrom owning or vending the factory; session construction creates both services from the shared provider.Validation
cargo check -p codex-corejust fix -p codex-corejust bazel-lock-updatejust bazel-lock-check