Skip to content

[codex-analytics] plumb protocol-native review timing#21434

Draft
rhan-oai wants to merge 1 commit intopr18747from
pr-review-timing-18748
Draft

[codex-analytics] plumb protocol-native review timing#21434
rhan-oai wants to merge 1 commit intopr18747from
pr-review-timing-18748

Conversation

@rhan-oai
Copy link
Copy Markdown
Collaborator

@rhan-oai rhan-oai commented May 6, 2026

Why

We want terminal tool review analytics, but the reducer should not stamp review timing from its own wall clock.

This PR plumbs review timing through the real protocol and app-server seams so the emitter PR can consume those timestamps directly.

What changed

  • add started_at_ms to user approval request payloads
  • add started_at_ms / completed_at_ms to guardian review notifications
  • stamp typed ServerResponse analytics facts with app-server-observed completed_at_ms
  • thread the new timing fields through core, protocol, app-server, TUI, and analytics fixtures

Verification

  • cargo test -p codex-app-server outgoing_message --manifest-path codex-rs/Cargo.toml
  • cargo test -p codex-app-server-protocol guardian --manifest-path codex-rs/Cargo.toml
  • cargo test -p codex-tui guardian --manifest-path codex-rs/Cargo.toml
  • cargo test -p codex-analytics analytics_client_tests --manifest-path codex-rs/Cargo.toml

Stack created with Sapling. Best reviewed with ReviewStack.

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

AnalyticsFact::ServerResponse {
response: _response,
} => {}

P1 Badge Include the new server-response timestamp in the pattern

Adding completed_at_ms to AnalyticsFact::ServerResponse leaves this match arm non-exhaustive, so codex-analytics no longer compiles (cargo check -p codex-analytics reports E0027). Ignore or bind the new field here before landing.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@rhan-oai rhan-oai force-pushed the pr-review-timing-18748 branch from f47e6da to b7fda8f Compare May 6, 2026 23:05
@rhan-oai rhan-oai force-pushed the pr-review-timing-18748 branch from b7fda8f to a6a4386 Compare May 6, 2026 23:18
@rhan-oai rhan-oai force-pushed the pr-review-timing-18748 branch from a6a4386 to 20cbbc4 Compare May 6, 2026 23:29
@rhan-oai rhan-oai force-pushed the pr-review-timing-18748 branch 3 times, most recently from 562e2d1 to 3b55049 Compare May 7, 2026 00:53
@rhan-oai rhan-oai marked this pull request as draft May 7, 2026 01:29
@rhan-oai rhan-oai force-pushed the pr-review-timing-18748 branch from 3b55049 to a7ac582 Compare May 7, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant