Conversation
There was a problem hiding this comment.
💡 Codex Review
apply_bespoke_event_handling no longer takes analytics_events_client, but this match arm still reads analytics_events_client.as_ref(). That unresolved identifier causes a compile failure (same issue also appears in warning/guardian-warning arms), blocking build and release.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| self.turn_item_started_at_ms | ||
| .lock() | ||
| .await | ||
| .insert(item.id(), started_at_ms); |
There was a problem hiding this comment.
Restrict start-time tracking to completable turn items
emit_turn_item_started stores every item ID in turn_item_started_at_ms, but some item types only emit a start event (e.g. ContextCompaction in core/src/compact.rs and core/src/compact_remote.rs) and never call emit_turn_item_completed. Those IDs are never removed, so long-lived sessions leak memory as compactions accumulate.
Useful? React with 👍 / 👎.
|
Closing duplicate stack created during resubmission; canonical PR remains #17090. |
Stack created with Sapling. Best reviewed with ReviewStack.