perf: batch Windows credential ACL inspection - #300
Merged
kmbroai merged 1 commit intoAug 7, 2026
Merged
Conversation
kmbroai
merged commit Aug 7, 2026
9721adf
into
dev/kyleb/windows-ci-credential-acl-flakes
16 checks passed
kmbroai
added a commit
that referenced
this pull request
Aug 7, 2026
* [codex-security] Stabilize Windows credential ACL verification * [codex-security] Allow slower Windows credential integration tests * [codex-security] Batch Windows credential ACL inspection (#300)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #298; this pull request is intentionally based on
dev/kyleb/windows-ci-credential-acl-flakesand does not modify that PR.Why
Windows credential workflows repeatedly validate the managed credential home. Before this change, each validation starts separate PowerShell processes for ancestry, the home, and existing descendants; a scan can repeat that work seven or eight times.
On the same #298 commit, the parallel-scan test takes 25.0 seconds on Windows versus 298 milliseconds on Linux, and the Windows suite takes 399.86 seconds versus 61.38 seconds on Linux. Historical Windows logs show one representative scan test increasing from 5.2 seconds to 26.4 seconds when managed ACL validation was introduced.
Verification
--randomize --seed 12345 --timeout 30000): 950 passed, 10 platform-specific skips, 0 failed across 960 tests.pnpm packand installed-package smoke validation passed, including the public import, CLI, 106 bundled plugin files, nested worker, and 198 archive entries.