Skip to content

fix: Windows spawn ENOENT and EISDIR errors (#116) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
D2758695161 wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −5
Open

fix: Windows spawn ENOENT and EISDIR errors (#116) #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16b613c
feat: add --full-access flag for danger-full-access sandbox
D2758695161 Apr 4, 2026
cde1ec7
fix: add shell: true on Windows in app-server.mjs spawn
D2758695161 Apr 5, 2026
a8eb41b
fix: handle directories in formatUntrackedFile to prevent EISDIR
D2758695161 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/codex/scripts/codex-companion.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ async function executeTaskRun(request) {
defaultPrompt: resumeThreadId ? DEFAULT_CONTINUE_PROMPT : "",
model: request.model,
effort: request.effort,
sandbox: request.write ? "workspace-write" : "read-only",
sandbox: request.fullAccess ? "danger-full-access" : (request.write ? "workspace-write" : "read-only"),
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Wire --full-access through to task execution

executeTaskRun now selects sandbox mode from request.fullAccess, but task requests built in handleTask never set that property, so this condition is always false. As a result, users can pass --full-access and still run in read-only/workspace-write, which silently breaks commands that need danger-full-access permissions.

Useful? React with 👍 / 👎.

onProgress: request.onProgress,
persistThread: true,
threadName: resumeThreadId ? null : buildPersistentTaskThreadName(request.prompt || DEFAULT_CONTINUE_PROMPT)
Expand Down Expand Up @@ -704,7 +704,7 @@ async function handleReview(argv) {
async function handleTask(argv) {
const { options, positionals } = parseCommandInput(argv, {
valueOptions: ["model", "effort", "cwd", "prompt-file"],
booleanOptions: ["json", "write", "resume-last", "resume", "fresh", "background"],
booleanOptions: ["json", "write", "full-access", "resume-last", "resume", "fresh", "background"],
aliasMap: {
m: "model"
}
Expand Down
6 changes: 3 additions & 3 deletions plugins/codex/scripts/lib/git.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ function formatSection(title, body) {
function formatUntrackedFile(cwd, relativePath) {
const absolutePath = path.join(cwd, relativePath);
const stat = fs.statSync(absolutePath);
if (stat.size > MAX_UNTRACKED_BYTES) {
return `### ${relativePath}\n(skipped: ${stat.size} bytes exceeds ${MAX_UNTRACKED_BYTES} byte limit)`;
if (stat.isDirectory()) {
return `### ${relativePath}
(skipped: directory)`;
}

const buffer = fs.readFileSync(absolutePath);
Comment on lines +139 to 143
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Reinstate max-size check before reading untracked files

The new directory guard removed the previous MAX_UNTRACKED_BYTES gate, so formatUntrackedFile now readFileSyncs every non-directory untracked file regardless of size. In working trees that contain large generated artifacts (logs, dumps, fixtures), /codex:review can consume excessive memory and produce oversized context payloads that fail or degrade review runs. Keep the directory skip, but also restore the size limit check before reading file contents.

Useful? React with 👍 / 👎.

if (!isProbablyText(buffer)) {
return `### ${relativePath}\n(skipped: binary file)`;
Expand Down