Skip to content

Add system version mixin#936

Merged
benderl merged 2 commits intoopenWB:mainfrom
Brett-S-OWB:system-version-mixin
Apr 1, 2026
Merged

Add system version mixin#936
benderl merged 2 commits intoopenWB:mainfrom
Brett-S-OWB:system-version-mixin

Conversation

@Brett-S-OWB
Copy link
Copy Markdown
Contributor

Die Logik zur Ermittlung der systemVersion wurde in ein eigenes Mixin ausgelagert (SystemVersion.vue) und in den betroffenen Komponenten eingebunden.

Not all Komponenten requiring systemVersion use ComponentState.vue, which previously led to duplication across mixins.
Centralizing the logic in a single mixin improves reusability and avoids duplication.

@Brett-S-OWB Brett-S-OWB requested a review from LKuemmel March 25, 2026 13:31
},
},
mounted() {
this.$root.doSubscribe(["openWB/system/version"]);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diese Zeile gehört dann aber auch nicht mehr hier hin.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stimmt, ich habe es hier entfernt und bei Mixin: SystemVersion.vue hinzugefügt.

@benderl benderl self-assigned this Mar 26, 2026
@benderl benderl added this to the 2.2.0 milestone Mar 26, 2026
@benderl benderl merged commit 9230169 into openWB:main Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants