Repository navigation
Improve support for input variable constraints - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
optikit-design.ymlsupported declaringminandmaxconstraints on input variables. However, those constraints were never actually used or checked in theoptikitCLI tool itself.This PR adds checks for
minandmaxconstraints, when the DSN is checked upon being loaded. This PR also allows declaring a list of allowed values for the variables; if the list is non-empty, then any provided values outside that list will be rejected.Finally, this PR adds error detection for errors in scripts in the
make generatecommand; previously, those errors weren't actually bubbling up into a CI run failure.