Skip to content

Move rgbd under reconstruction, transport to core, study under streamer - #59

Closed
ryanmkim wants to merge 4 commits into
mainfrom
reorganize-reconstruction-streamer
Closed

ryanmkim wants to merge 4 commits into
mainfrom
reorganize-reconstruction-streamer

Conversation

@ryanmkim

@ryanmkim ryanmkim commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator
  • open4d/streaming → open4d/reconstruction/rgbd (open4d.reconstruction.rgbd)
  • TCP send/receive → open4d/transport, in the core package
  • open4d/webclients → open4d/streamer/study, beside the streamer package, not in its wheel

Public API is unchanged. Packaging, MANIFEST, CI, provenance/wheel checks and docs updated to match. Supersedes rename-rgbd-transport, without its browser-only stream() change.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Too many files!

This PR contains 183 files, which is 83 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 94dc099c-d88b-41dd-90a7-a0bab8f21cd8

📥 Commits

Reviewing files that changed from the base of the PR and between 92eb0b8 and bd5557b.

⛔ Files ignored due to path filters (13)
  • open4d/streamer/study/system/Client/traces/amazonfcc.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/cascade-20.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/cascade-5.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/good-wifi.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/lte.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/nuwave-0-20.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/nuwave_trace.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/nuwins-60-80.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/nuwins_trace.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Client/traces/poor-wifi.csv is excluded by !**/*.csv
  • open4d/streamer/study/system/Server/package-lock.json is excluded by !**/package-lock.json
  • open4d/streamer/study/system/WebClient/package-lock.json is excluded by !**/package-lock.json
  • open4d/streamer/study/system/WebClient/vendor/draco/draco_decoder.wasm is excluded by !**/*.wasm
📒 Files selected for processing (183)
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
  • MANIFEST.in
  • README.md
  • THIRD_PARTY.md
  • docs/api.md
  • docs/components.md
  • docs/requirements.md
  • open4d/__init__.py
  • open4d/_api.py
  • open4d/reconstruction/__init__.py
  • open4d/reconstruction/rgbd/.gitignore
  • open4d/reconstruction/rgbd/CMakeLists.txt
  • open4d/reconstruction/rgbd/README.md
  • open4d/reconstruction/rgbd/__init__.py
  • open4d/reconstruction/rgbd/_reconstruction.py
  • open4d/reconstruction/rgbd/app/CMakeLists.txt
  • open4d/reconstruction/rgbd/app/dual_camera_fusion.cpp
  • open4d/reconstruction/rgbd/app/register_meshes.cpp
  • open4d/reconstruction/rgbd/app/rgbd_live_streamer.cpp
  • open4d/reconstruction/rgbd/app/rgbd_streamer.cpp
  • open4d/reconstruction/rgbd/app/sensor_client.cpp
  • open4d/reconstruction/rgbd/config.dual.json
  • open4d/reconstruction/rgbd/config.json
  • open4d/reconstruction/rgbd/config.live.json
  • open4d/reconstruction/rgbd/config.rgbd-tcp.json
  • open4d/reconstruction/rgbd/config.rgbd.json
  • open4d/reconstruction/rgbd/config.single-camera-1.json
  • open4d/reconstruction/rgbd/include/capture_thread.hpp
  • open4d/reconstruction/rgbd/include/data_type.hpp
  • open4d/reconstruction/rgbd/include/pipe.hpp
  • open4d/reconstruction/rgbd/include/reconstruction/reconstruction.hpp
  • open4d/reconstruction/rgbd/include/reconstruction/texture_mapping.hpp
  • open4d/reconstruction/rgbd/include/reconstruction/texture_mapping_cuda.hpp
  • open4d/reconstruction/rgbd/include/sensor/cv_convert_util.hpp
  • open4d/reconstruction/rgbd/include/sensor/kinect_cameras.hpp
  • open4d/reconstruction/rgbd/include/sensor/kinect_capture.hpp
  • open4d/reconstruction/rgbd/include/streaming/network_stream.hpp
  • open4d/reconstruction/rgbd/include/streaming/send_image.hpp
  • open4d/reconstruction/rgbd/include/streaming/sender_to_unity.hpp
  • open4d/reconstruction/rgbd/include/util.hpp
  • open4d/reconstruction/rgbd/python/live_two_camera_fusion.py
  • open4d/reconstruction/rgbd/python/live_two_camera_webrtc.py
  • open4d/reconstruction/rgbd/python/protocol.py
  • open4d/reconstruction/rgbd/src/CMakeLists.txt
  • open4d/reconstruction/rgbd/src/reconstruction/CMakeLists.txt
  • open4d/reconstruction/rgbd/src/reconstruction/reconstruction.cpp
  • open4d/reconstruction/rgbd/src/reconstruction/texture_mapping.cpp
  • open4d/reconstruction/rgbd/src/reconstruction/texture_mapping_cuda.cu
  • open4d/reconstruction/rgbd/src/sensor/CMakeLists.txt
  • open4d/reconstruction/rgbd/src/sensor/kinect_cameras.cpp
  • open4d/reconstruction/rgbd/src/sensor/kinect_capture.cpp
  • open4d/reconstruction/rgbd/src/streaming/CMakeLists.txt
  • open4d/reconstruction/rgbd/src/streaming/network_stream.cpp
  • open4d/reconstruction/rgbd/src/streaming/send_image.cpp
  • open4d/reconstruction/rgbd/src/streaming/sender_to_unity.cpp
  • open4d/reconstruction/rgbd/src/util.cpp
  • open4d/reconstruction/rgbd/tests/network_stream_test.cpp
  • open4d/reconstruction/rgbd/tests/pipe_test.cpp
  • open4d/reconstruction/rgbd/tests/test_capture.py
  • open4d/reconstruction/rgbd/tests/test_native.py
  • open4d/reconstruction/rgbd/tests/test_reconstruction.py
  • open4d/reconstruction/rgbd/tests/texture_mapping_cuda_test.cpp
  • open4d/reconstruction/rgbd/tools/receive_live_stream.py
  • open4d/reconstruction/rgbd/tools/receive_mesh_frame.py
  • open4d/reconstruction/rgbd/tools/reconstruct_saved_two_camera.py
  • open4d/reconstruction/rgbd/tools/replay_obp1_sender.py
  • open4d/reconstruction/rgbd/tools/run_browser_viewer.sh
  • open4d/reconstruction/rgbd/tools/run_remote_two_camera_fusion.sh
  • open4d/streamer/README.md
  • open4d/streamer/study/.gitignore
  • open4d/streamer/study/PROVENANCE
  • open4d/streamer/study/README.md
  • open4d/streamer/study/scene_layout.json
  • open4d/streamer/study/scripts/run_web_demo.sh
  • open4d/streamer/study/scripts/serve_pointcloud_baseline.sh
  • open4d/streamer/study/scripts/shape_web_demo.sh
  • open4d/streamer/study/system/ClientCore/README.md
  • open4d/streamer/study/system/ClientCore/abr.js
  • open4d/streamer/study/system/ClientCore/bandwidth-estimator.js
  • open4d/streamer/study/system/ClientCore/bandwidth.js
  • open4d/streamer/study/system/ClientCore/download-plan.js
  • open4d/streamer/study/system/ClientCore/link-throughput.js
  • open4d/streamer/study/system/ClientCore/metrics.js
  • open4d/streamer/study/system/ClientCore/payloads.js
  • open4d/streamer/study/system/ClientCore/platform.js
  • open4d/streamer/study/system/ClientCore/stalls.js
  • open4d/streamer/study/system/ClientCore/stream-config.js
  • open4d/streamer/study/system/ClientCore/streaming-client.js
  • open4d/streamer/study/system/ClientCore/testing/fake-platform.js
  • open4d/streamer/study/system/Server/package.json
  • open4d/streamer/study/system/Server/public/index.html
  • open4d/streamer/study/system/Server/quest-launch.json
  • open4d/streamer/study/system/Server/quest-trace-player.js
  • open4d/streamer/study/system/Server/server.js
  • open4d/streamer/study/system/Server/study/follower.js
  • open4d/streamer/study/system/Server/study/order.js
  • open4d/streamer/study/system/Server/study/questionnaire.js
  • open4d/streamer/study/system/Server/study/routes.js
  • open4d/streamer/study/system/Server/study/shaper.js
  • open4d/streamer/study/system/Server/study/store.js
  • open4d/streamer/study/system/Server/study/trace.js
  • open4d/streamer/study/system/Server/test_offline_trajectory.js
  • open4d/streamer/study/system/Server/test_quest_trace_player.js
  • open4d/streamer/study/system/WebClient/README.md
  • open4d/streamer/study/system/WebClient/bridge/v4ds-bridge.js
  • open4d/streamer/study/system/WebClient/build.js
  • open4d/streamer/study/system/WebClient/package.json
  • open4d/streamer/study/system/WebClient/public/baseline.html
  • open4d/streamer/study/system/WebClient/public/index.html
  • open4d/streamer/study/system/WebClient/public/mesh.html
  • open4d/streamer/study/system/WebClient/public/nevo.html
  • open4d/streamer/study/system/WebClient/public/vega.html
  • open4d/streamer/study/system/WebClient/src/baseline-client.js
  • open4d/streamer/study/system/WebClient/src/baseline-main.js
  • open4d/streamer/study/system/WebClient/src/browser-platform.js
  • open4d/streamer/study/system/WebClient/src/camera-pose.js
  • open4d/streamer/study/system/WebClient/src/decode-cache.js
  • open4d/streamer/study/system/WebClient/src/draco-worker.js
  • open4d/streamer/study/system/WebClient/src/link-rate.js
  • open4d/streamer/study/system/WebClient/src/main.js
  • open4d/streamer/study/system/WebClient/src/nevo-client.js
  • open4d/streamer/study/system/WebClient/src/nevo-main.js
  • open4d/streamer/study/system/WebClient/src/nevo-manifest.js
  • open4d/streamer/study/system/WebClient/src/point-reconstruction.js
  • open4d/streamer/study/system/WebClient/src/point-renderer.js
  • open4d/streamer/study/system/WebClient/src/splat-renderer.js
  • open4d/streamer/study/system/WebClient/src/study/camera.js
  • open4d/streamer/study/system/WebClient/src/study/driver.js
  • open4d/streamer/study/system/WebClient/src/study/harness.js
  • open4d/streamer/study/system/WebClient/src/study/questionnaire-form.js
  • open4d/streamer/study/system/WebClient/src/study/study-page.js
  • open4d/streamer/study/system/WebClient/src/texture-decoder.js
  • open4d/streamer/study/system/WebClient/src/v4ds-protocol.js
  • open4d/streamer/study/system/WebClient/src/vega-client.js
  • open4d/streamer/study/system/WebClient/src/vega-main.js
  • open4d/streamer/study/system/WebClient/src/vgs-format.js
  • open4d/streamer/study/system/WebClient/src/webgl-renderer.js
  • open4d/streamer/study/system/WebClient/vendor/draco/draco_decoder.js
  • open4d/streamer/study/tests/fixtures/view_00.json
  • open4d/streamer/study/tests/fixtures_nevo_manifest.json
  • open4d/streamer/study/tests/fixtures_recon_golden.gen.py
  • open4d/streamer/study/tests/fixtures_recon_golden.json
  • open4d/streamer/study/tests/fixtures_v4ds_golden.gen.py
  • open4d/streamer/study/tests/fixtures_v4ds_golden.json
  • open4d/streamer/study/tests/fixtures_vgs_golden.gen.py
  • open4d/streamer/study/tests/fixtures_vgs_golden.json
  • open4d/streamer/study/tests/test_bandwidth_estimator.js
  • open4d/streamer/study/tests/test_browser_platform.js
  • open4d/streamer/study/tests/test_camera_pose.js
  • open4d/streamer/study/tests/test_client_core.js
  • open4d/streamer/study/tests/test_client_core_parity.js
  • open4d/streamer/study/tests/test_client_core_purity.js
  • open4d/streamer/study/tests/test_client_platform.js
  • open4d/streamer/study/tests/test_decode_cache.js
  • open4d/streamer/study/tests/test_link_rate.js
  • open4d/streamer/study/tests/test_nevo_manifest.js
  • open4d/streamer/study/tests/test_point_reconstruction.js
  • open4d/streamer/study/tests/test_streaming_client.js
  • open4d/streamer/study/tests/test_study_bridge.js
  • open4d/streamer/study/tests/test_study_camera.js
  • open4d/streamer/study/tests/test_study_session.js
  • open4d/streamer/study/tests/test_study_shaper.js
  • open4d/streamer/study/tests/test_tile_ladder.py
  • open4d/streamer/study/tests/test_v4ds_bridge.js
  • open4d/streamer/study/tests/test_v4ds_protocol.js
  • open4d/streamer/study/tests/test_vgs_format.js
  • open4d/streamer/study/tests/test_web_client_bundle.js
  • open4d/streamer/study/tile_ladder.py
  • open4d/streaming/README.md
  • open4d/streaming/REMOTE_TWO_CAMERA.md
  • open4d/streaming/__init__.py
  • open4d/streaming/tests/test_python.py
  • open4d/transport/__init__.py
  • open4d/transport/_tcp.py
  • open4d/transport/tests/test_tcp.py
  • open4d/webclients/README.md
  • open4d/webclients/system/ClientCore/README.md
  • open4d/webclients/system/WebClient/README.md
  • pyproject.toml
  • scripts/check_provenance.py
  • scripts/check_wheel_contents.py
  • scripts/tests/test_check_provenance.py

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ryanmkim

Copy link
Copy Markdown
Collaborator Author

Study fixes: record the bridge's shaping for ViVo/NAVA trials, preload Vega before the trace, and fix Vega's splat size in study mode (was 70% coverage at 8 fps; now 30 fps). Trials also record the GL renderer and warn on software rendering.

@cicm4 cicm4 closed this Oct 21, 2026
@cicm4
cicm4 deleted the reorganize-reconstruction-streamer branch October 21, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants