Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Small QUEEN scenes and disabled gates could not save compressed frames; 3DGStream's defaults could crash or restart a temporal frame from its input cloud; short TSMC clips indexed nonexistent frames. These paths now complete actual training, encoding, decoding and playback.
This PR targets
codex/library-api-and-bug-fixes, the existing API branch used for validation, and contains 23 repair, regression-test, dependency and documentation files.Verification
Original repair commit (
4cb577b):python -m pytest -qon macOS / Apple Silicon, Python 3.12.13 and Torch 2.7.0: 616 passed, 17 skipped, no failures. This checkout excludes four pre-existing local editor/viewer edits. The earlier 618-pass audit included those edits. Markdown-link and provenance checks andgit diff --checkalso pass on the PR checkout.CI compatibility update (
62c772f): All 24 GitHub CI jobs pass, including Open3D on Python 3.10–3.12 and clean-wheel installation across Linux, macOS and Windows on Python 3.10–3.13. Local reconstruction/transport verification passed 31 tests (one external native-codec skip); seven unsupported-version/validation checks passed in an Open3D 0.20 environment. The five empty-mesh failures reproduced with 0.20 and passed with 0.19 while keeping NumPy 2.5.3 unchanged.Native CUDA regressions: Linux / RTX 4090, Python 3.10.16, Torch 2.6.0+cu124, and the rebuilt bundled rasterizer:
These suites overlap; their counts are not a combined unique-test total. Before the repairs, focused regressions reproduced failures in QUEEN (8/9), 3DGStream (4/4), TSMC reference selection (5/6), N4MC auto selection (1/1), and the near-camera rasterizer (2/3).
Actual workflows:
--evalor an explicit temporal-load override. Logs confirm loading iteration 30 followed by iteration 10.Wheel and sdist builds, both distribution-boundary checks, an isolated installed-wheel I/O/CLI/mesh-TCP smoke run, and supported-path compilation passed during the fix audit. The expected publication block remains in place. Executed native source files were hash-checked against the 20 repair files in this branch. Logs, bitstreams and ten playback recordings are retained locally with the audit report; generated artifacts and datasets are not committed.
Safety checklist
THIRD_PARTY.mdwas updated for copied code, data, models, papers, media, binaries, or submodules.Remaining limitations
The rasterizer source fix requires rebuilding
diff-gaussian-rasterizationin each affected environment; the tested server environment was rebuilt. Separately cached native TSMC checkouts need the updated reference-center script when selected as a backend override.Native N4MC MPS support remains unavailable in the tested Torch runtime; automatic execution now uses CPU. These are short functional runs, not production-quality or sustained-load benchmarks. Some streamed novel views show blur/ghosting with the short training budgets. Standalone SIBR residual playback and browser-side Gaussian decoding were not verified.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.