feat: Update contributing guide - #432
Open
lornakelly wants to merge 1 commit into
Open
lornakelly wants to merge 1 commit into
lornakelly wants to merge 1 commit into
Conversation
Signed-off-by: lornakelly <lornakelly88@gmail.com>
✅ Deploy Preview for openworkflow-editor canceled.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The only noted issue is a minor documentation nit, with no blocking issues.
Pull request overview
Updates CONTRIBUTING.md with Git identity and DCO guidance to reduce sign-off failures.
Changes:
- Adds Git identity configuration instructions.
- Documents private GitHub email usage and squash-merge DCO behavior.
- Links identity setup from the pull request checklist.
File summaries
| File | Summary |
|---|---|
CONTRIBUTING.md |
Adds Git identity and DCO guidance; includes a minor nit about global versus repository-local Git configuration. |
Review details
Suppressed comments (1)
CONTRIBUTING.md:195
- These commands write to the global Git config, so they change the identity used by every repository, while any existing repository-local
user.name/user.emailwill override them. Since this section is configuring the identity for this contribution, use repository-local commands (or explicitly document the precedence and global side effect) so the setting actually controls commits here without affecting unrelated accounts.
git config --global user.name "<your GitHub display name, or your username if none is set>"
git config --global user.email "<your GitHub account email>"
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lornakelly
requested review from
fantonangeli,
handreyrc and
kumaradityaraj
September 15, 2026 09:41
fantonangeli
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #431
Update CONTRIBUTING.md file with instructions on setting local github config to github account