fix #387 - feat: Deploy released Editor versions to GitHub Pages - #393
Conversation
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
✅ Deploy Preview for openworkflow-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
Workflow validation, initial branch setup, retry behavior, and broken root links currently block reliable deployment.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds versioned Storybook deployments to GitHub Pages as part of releases.
Changes:
- Adds reusable Pages deployment workflow.
- Connects deployment to publishing.
- Documents release URLs and manual deployment.
File summaries
| File | Description |
|---|---|
.github/workflows/deploy-pages.yaml |
Builds tagged releases and deploys versioned Storybooks. |
.github/workflows/publish-release.yaml |
Triggers Pages deployment after publishing. |
RELEASE_PROCESS.md |
Documents deployment behavior. |
README.md |
Links to released editor. |
packages/open-workflow-diagram-editor/README.md |
Adds released-editor link. |
Review details
Suppressed comments (2)
.github/workflows/deploy-pages.yaml:87
- The initial deployment cannot reach the build because this checkout requires
gh-pagesto exist, but the repository currently has no such branch. Please either initialize the branch as part of this workflow or provision and document it as a prerequisite before enabling the release job.
- name: Checkout gh-pages
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
ref: gh-pages
path: pages
.github/workflows/deploy-pages.yaml:105
- A redeploy of an unchanged version exits here because
git commitreturns status 1 when there are no staged changes. In particular, if a prior run pushed the branch and then failed during Pages deployment, the documented retry will fail before uploading; allow a no-op commit while still proceeding to deployment.
git commit -s -m "deploy: ${DEPLOY_PREVIEW_PACKAGE_NAME}@${{ inputs.version }}"
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
This is intentional. If there are no changes to commit, git commit will fail with nothing to commit, working tree clean, and the failure will be visible in the CI run logs. |
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
…oy-released-Editor-versions-to-GitHub-Pages Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Release deployment is blocked by incompatible setup and Changesets inputs, while no-op redeployments can fail.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 3
- Review effort level: Balanced
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The deployment currently fails during cache setup and exposes an unsafe manual version input to privileged shell commands.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Balanced
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
Pages enablement is missing from rollout setup, and concurrency can silently skip overlapping version deployments.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
.github/workflows/deploy-pages.yaml:48
- This does not fully serialize deployments: GitHub Actions retains at most one pending run per concurrency group and cancels an older pending run when another arrives, even with
cancel-in-progress: false. If three releases or manual backfills overlap, the middle version is never added togh-pages, contradicting the requirement to retain every release. Use a queue that preserves every run, or detect/retry canceled version deployments while still preventing concurrent branch pushes.
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
lornakelly
left a comment
There was a problem hiding this comment.
@fantonangeli Thanks, looks really nice, and simpler to the way I had it :)
Just added a couple of comments. I will work on actions listed in PR description as well
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
🟡 Changes recommended
The concurrency configuration can skip deployments or regress the latest pointer when releases overlap.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
| concurrency: | ||
| group: deploy-pages | ||
| cancel-in-progress: false |
|
Confirming that @fantonangeli and I completed the actions required section of the PR |
Signed-off-by: Fabrizio Antonangeli <fabrizio.antonangeli@gmail.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The /latest/ links need an initial backfill because gh-pages is empty and automatic deployment awaits a future release.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
README.md:24
- The new public link will still return 404 after this merges: the
gh-pagesbranch is currently empty, while the automatic deployment only runs after a future release PR publishes. Please include an initialworkflow_dispatchbackfill of1.1.0withlatest=truein the rollout (or seed/latest/before exposing these links), otherwise every newly added “latest” link remains broken until the next release.
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
@lornakelly can you please merge this |
5907e9d
into
open-workflow-specification:main
Closes #387
❗ Actions required:
gh-pagesbranchDescription
Deploy released Editor versions to GitHub Pages.
Motivation
The Editor is currently deployed to Netlify from
main.This is useful for development and pull request previews, but the Open Workflow Specification website should link to a deployed released version of the Editor instead of showing unreleased changes from
main.Proposed Implementation
Deploy the Editor to GitHub Pages as part of the release process.
The deployment should:
main.