Repository navigation
Fix dashboard reviewer age after explicit handoffs - #518
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pull request dashboard statusMerged · refreshed 2026-11-07 16:18 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The routing logic can permanently miss a later review re-request when a pre-handoff maintainer wait is cached, incorrectly using an older command timestamp.
1 open issue
What changed in this PR
This PR updates dashboard reviewer ages to start at explicit /dashboard route:reviewers handoffs rather than older activity or pending threads.
Changes:
- Uses the active handoff timestamp as a lower bound for reviewer wait ages.
- Adds regression coverage for refreshes, pushes, route progression, and later review re-requests.
- Bumps the dashboard state version to recalculate cached ages and documents the new behavior.
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents handoff-based reviewer ages. |
.github/scripts/pull-request-dashboard/test_state.py |
Updates the expected dashboard state version to 20. |
.github/scripts/pull-request-dashboard/test_routing_decision.py |
Adds handoff age and persistence regression cases. |
.github/scripts/pull-request-dashboard/state.py |
Bumps the dashboard state version to 20. |
.github/scripts/pull-request-dashboard/routing_decision.py |
Applies active handoff timestamps to reviewer wait ages. |
.github/scripts/pull-request-dashboard/RATIONALE.md |
Explains explicit handoff timing and re-request precedence. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reset can override a later explicit handoff with an earlier review re-request, discarding accrued wait time; event ordering needs correction and a request-before-command regression test.
1 open issue
1 resolved since last review
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Kielek
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Start the reviewer waiting age at the effective timestamp of
/dashboard route:reviewers, rather than older author activity or pending threads. This fixes cases like open-telemetry/opentelemetry-java-instrumentation#19526, which showed18dimmediately after a handoff.Order handoffs and human review re-requests by their GitHub event timestamps, not when a refresh discovers them. Preserve the wait across refreshes, pushes, and progression to maintainers, while allowing a later re-request to start a new wait.
Bump the dashboard state version so cached ages are recalculated and older delivery workers cannot publish stale semantics.