Skip to content

Fix dashboard reviewer age after explicit handoffs - #518

Merged
trask merged 3 commits into
mainfrom
trask-dashboard-reviewer-age
Nov 7, 2026
Merged

trask merged 3 commits into
mainfrom
trask-dashboard-reviewer-age

Conversation

@trask

@trask trask commented Nov 7, 2026 •

Copy link
Copy Markdown
Member

Start the reviewer waiting age at the effective timestamp of /dashboard route:reviewers, rather than older author activity or pending threads. This fixes cases like open-telemetry/opentelemetry-java-instrumentation#19526, which showed 18d immediately after a handoff.

Order handoffs and human review re-requests by their GitHub event timestamps, not when a refresh discovers them. Preserve the wait across refreshes, pushes, and progression to maintainers, while allowing a later re-request to start a new wait.

Bump the dashboard state version so cached ages are recalculated and older delivery workers cannot publish stale semantics.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@trask
trask requested a balanced review from Copilot November 7, 2026 03:57
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-11-07 16:18 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The routing logic can permanently miss a later review re-request when a pre-handoff maintainer wait is cached, incorrectly using an older command timestamp.

1 open issue
What changed in this PR

This PR updates dashboard reviewer ages to start at explicit /dashboard route:reviewers handoffs rather than older activity or pending threads.

Changes:

  • Uses the active handoff timestamp as a lower bound for reviewer wait ages.
  • Adds regression coverage for refreshes, pushes, route progression, and later review re-requests.
  • Bumps the dashboard state version to recalculate cached ages and documents the new behavior.
File Description
pull-request-dashboard/​README.md Documents handoff-based reviewer ages.
.github/​scripts/​pull-request-dashboard/​test_state.py Updates the expected dashboard state version to 20.
.github/​scripts/​pull-request-dashboard/​test_routing_decision.py Adds handoff age and persistence regression cases.
.github/​scripts/​pull-request-dashboard/​state.py Bumps the dashboard state version to 20.
.github/​scripts/​pull-request-dashboard/​routing_decision.py Applies active handoff timestamps to reviewer wait ages.
.github/​scripts/​pull-request-dashboard/​RATIONALE.md Explains explicit handoff timing and re-request precedence.

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The reset can override a later explicit handoff with an earlier review re-request, discarding accrued wait time; event ordering needs correction and a request-before-command regression test.

1 open issue
1 resolved since last review

Review effort: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the reviewer waiting-age changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@trask
trask marked this pull request as ready for review November 7, 2026 04:20
@trask
trask requested a review from a team as a code owner November 7, 2026 04:20
@trask
trask requested a review from Kielek November 7, 2026 04:20
@trask
trask merged commit ec82191 into main Nov 7, 2026
7 checks passed
@trask
trask deleted the trask-dashboard-reviewer-age branch November 7, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants