Repository navigation
Fix GitHub Actions queue collector completion gaps - #472
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 64d32fdf-1825-4d3f-8f47-63bafb80a01a
Pull request dashboard statusMerged · refreshed 2026-10-15 15:58 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified, and regression tests cover the changed completion and exclusion behavior.
0 open findings
What changed in this PR
Fixes completion handling in the GitHub Actions queue collector while preserving pagination and checkpoint behavior.
Changes:
- Excludes runnerless jobs before checking completion and accepts stale
queuedstatuses with terminal evidence. - Reports exclusion counts across live collection, backfill, and pending retries.
- Adds regression tests and documents the updated behavior.
| File | Description |
|---|---|
| github-actions-queue/README.md | Documents completion rules and exclusion counts. |
| .github/scripts/github-actions-queue/test_collect.py | Tests completion evidence, pagination, and checkpoint-aware counts. |
| .github/scripts/github-actions-queue/collect.py | Updates completion filtering and exclusion accounting. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Kielek
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalize completed workflow runs blocked only by runnerless jobs or stale
queuedstatuses. Likein_progress, queued jobs still need both a terminal conclusion and a completion timestamp.Collection summaries now report exclusions for retained work:
{"exclusions":{"runnerless_jobs":3,"runnerless_runs":1,"negative_queue_jobs":2}}Runnerless jobs no longer block assigned siblings. Entirely runnerless completed runs finalize without records, while assigned jobs missing completion evidence still keep the whole run pending.