Skip to content

Remove retired data snapshot rollout flag - #471

Merged
trask merged 1 commit into
mainfrom
trask-remove-snapshot-rollout-flag
Oct 14, 2026
Merged

trask merged 1 commit into
mainfrom
trask-remove-snapshot-rollout-flag

Conversation

@trask

@trask trask commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Remove the remaining DATA_BRANCH_SNAPSHOTS workflow injection now that unconditional snapshot storage is released and promoted and older writers have retired.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8fdf6fe0-0e03-49a2-ad0c-f84786acfdd8

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The scoped cleanup preserves snapshot safeguards, release selection, and operational controls, with no blocking issues identified.

0 open findings

What changed in this PR

Removes the retired DATA_BRANCH_SNAPSHOTS workflow injection while preserving permanent snapshot safety and processor environment inheritance coverage.

Changes:

  • Removes obsolete flag injection from dashboard and collector workflows.
  • Updates regression tests for flag removal and unset-variable behavior.
  • Documents post-merge variable deletion and restrictions on older processors.
File Description
pull-request-dashboard/​README.md Documents obsolete variable cleanup.
github-actions-queue/​README.md Clarifies unconditional snapshot storage.
.github/​workflows/​pull-request-dashboard-refresh-author-nudges.yml Removes flag injection from reminder sweeps.
.github/​workflows/​pull-request-dashboard-drain.yml Removes flag injection from queue draining.
.github/​workflows/​github-actions-queue-collector.yml Removes flag injection from data operations.
.github/​scripts/​pull-request-dashboard/​WEBHOOK_SETUP.md Updates cleanup guidance and preserves rollback restrictions.
.github/​scripts/​pull-request-dashboard/​test_rollout.py Checks workflows no longer reference the flag.
.github/​scripts/​pull-request-dashboard/​test_owned_execution.py Preserves generic environment inheritance coverage.
.github/​scripts/​pull-request-dashboard/​test_data_snapshots.py Adds snapshot coverage with the flag unset.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@trask
trask marked this pull request as ready for review October 14, 2026 16:31
@trask
trask requested a review from a team as a code owner October 14, 2026 16:31
@trask
trask requested a review from mx-psi October 14, 2026 16:31
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-14 17:37 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@trask
trask merged commit 7c3d47e into main Oct 14, 2026
8 checks passed
@trask
trask deleted the trask-remove-snapshot-rollout-flag branch October 14, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants