Repository navigation
Make generated-data storage permanently snapshot-only - #466
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 98f8a22d-3c9b-46aa-aac1-5e8210583aaa
Pull request dashboard statusMerged · refreshed 2026-10-14 14:56 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation, compatibility wiring, tests, and documentation consistently support unconditional snapshot storage.
0 open findings
What changed in this PR
Makes generated-data branches permanently snapshot-only while preserving compatibility with pinned v0.20.0 processors.
Changes:
- Removes environment-gated snapshot behavior.
- Preserves generation ordering, stale-head detection, and push leases.
- Updates tests, workflow fetching, and operational documentation.
| File | Description |
|---|---|
pull-request-dashboard/README.md |
Documents permanent snapshots and transition requirements. |
github-actions-queue/README.md |
Updates queue storage guidance. |
.github/workflows/github-actions-queue-collector.yml |
Unconditionally fetches legacy history. |
.github/scripts/pull-request-dashboard/WEBHOOK_SETUP.md |
Replaces cutover instructions with permanent-operation guidance. |
.github/scripts/pull-request-dashboard/test_state_branch.py |
Updates unit tests for snapshot ordering. |
.github/scripts/pull-request-dashboard/test_rollout.py |
Verifies compatibility wiring and collector fetching. |
.github/scripts/pull-request-dashboard/test_data_snapshots.py |
Expands snapshot integration coverage. |
.github/scripts/pull-request-dashboard/state_branch.py |
Makes snapshot reads and writes unconditional. |
.github/scripts/github-actions-queue/DATA_BRANCH_README.md |
Documents snapshot-only data storage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mx-psi
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make generated-data storage unconditionally snapshot-only. Writes retain the complete current tree in a parentless commit, with generation ordering, stale-head protection, and exact force-with-lease expectations preserved. Stored JSON formats and delivery receipts are unchanged.
Keep
DATA_BRANCH_SNAPSHOTS=trueand all workflow environment injection for pinned v0.20.0 processors. Remove that wiring only after releasing and promoting the unconditional helper and retiring older writers. Stable/canary selection and release pins are unchanged.The collector fetches full history for heads without snapshot metadata regardless of the variable, so a shallow fetch cannot hide history appended after a snapshot.