[CONFIGURATION] Add periodic metric reader builder support to registry#4277
Merged
dbarker merged 11 commits intoJul 24, 2026
Merged
Conversation
…ig test components to a shared test header Assisted by: Claude 4.6
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4277 +/- ##
==========================================
- Coverage 81.31% 81.25% -0.06%
==========================================
Files 445 446 +1
Lines 18859 18872 +13
==========================================
- Hits 15333 15332 -1
- Misses 3526 3540 +14
🚀 New features to boost your workflow:
|
… it may hang on force flush and timeout the tests
dbarker
marked this pull request as ready for review
July 23, 2026 02:52
lalitb
reviewed
Jul 23, 2026
lalitb
approved these changes
Jul 23, 2026
lalitb
reviewed
Jul 23, 2026
lalitb
approved these changes
Jul 24, 2026
marcalff
approved these changes
Jul 24, 2026
dbarker
enabled auto-merge (squash)
July 24, 2026 19:40
om7057
added a commit
to om7057/opentelemetry-cpp
that referenced
this pull request
Jul 25, 2026
The merge of main's registry-based PeriodicMetricReaderBuilder (open-telemetry#4277) left CreatePeriodicMetricReader() with unreachable dead code and a reference to the now-removed PeriodicExportingMetricReaderFactory direct-construction path, breaking the build across all CI jobs. Restore the registry builder flow and apply cardinality-limit enforcement to the reader it produces. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
om7057
added a commit
to om7057/opentelemetry-cpp
that referenced
this pull request
Jul 25, 2026
The merge of main's registry-based PeriodicMetricReaderBuilder (open-telemetry#4277) left CreatePeriodicMetricReader() with unreachable dead code and a reference to the now-removed PeriodicExportingMetricReaderFactory direct-construction path, breaking the build across all CI jobs. Restore the registry builder flow and apply cardinality-limit enforcement to the reader it produces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4243 (comment)
The configuration tests instantiated the PeriodicMetricReader and call ForceFlush. This caused tests to timeout sporadically. This PR extends the config registry and SDK builder to support setting a builder for the periodic metric reader. A synchronous mock reader is then used in configuration tests to verify config components.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes