Skip to content

Unref WebSocket stop timeout to prevent lingering timers#866

Open
BelfordZ wants to merge 1 commit intomasterfrom
fix/fix-websocket-server-shutdown-timers
Open

Unref WebSocket stop timeout to prevent lingering timers#866
BelfordZ wants to merge 1 commit intomasterfrom
fix/fix-websocket-server-shutdown-timers

Conversation

@BelfordZ
Copy link
Copy Markdown
Member

Summary

  • avoid keeping event loop alive by calling unref on WebSocketServerTransport stop timeout
  • add unit test to ensure timeout is unrefed

Testing

  • npm test

https://chatgpt.com/codex/tasks/task_e_68b33c68613c832faf956dcd076a4927

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (eee4a4d) to head (75f9500).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   98.96%   98.96%           
=======================================
  Files           9        9           
  Lines         289      290    +1     
  Branches       43       43           
=======================================
+ Hits          286      287    +1     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant