Skip to content

Issue1462 no git lfs #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelgerjansen merged 4 commits into from
Sep 9, 2025
Merged

Issue1462 no git lfs #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85376d0
Split large validation file into multiple ones and remove git lfs
jelgerjansen Sep 3, 2025
9d24ad2
Update documentation and revision notes
jelgerjansen Sep 3, 2025
8ca3e44
Update final time script
jelgerjansen Sep 3, 2025
19eb9ad
Update version date
jelgerjansen Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@
# Denote all files that are truly binary and should not be modified.
*.png binary
*.jpg binary
IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements.txt filter=lfs diff=lfs merge=lfs -text
9 changes: 7 additions & 2 deletions IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_Electrical.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@
model PVT_UN_Electrical
"Electrical Behavior of Unglazed Rear-Non-Insulated PVT Collector"
extends Modelica.Icons.Example;

replaceable package Medium = IDEAS.Media.Antifreeze.PropyleneGlycolWater (
property_T = 293.15,
X_a = 0.43);
parameter String week = "week1";
parameter Modelica.Units.SI.Temperature T_start = 17.086651 + 273.15 "Initial temperature (from measurement data)";
parameter Real eleLosFac = 0.07;

inner Modelica.Blocks.Sources.CombiTimeTable meaDat(
tableOnFile=true,
tableName="data",
fileName=Modelica.Utilities.Files.loadResource("modelica://IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements.txt"),
fileName=Modelica.Utilities.Files.loadResource("modelica://IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements_"+week+".txt"),
columns=1:26) annotation (Placement(transformation(extent={{-92,24},{-72,44}})));

Modelica.Thermal.HeatTransfer.Celsius.ToKelvin TFluKel annotation (Placement(transformation(extent={{-87,-1},
Expand Down Expand Up @@ -100,6 +100,11 @@ even under challenging real-world conditions.
revisions="<html>
<ul>
<li>
September 3, 2025, by Jelger Jansen:<br/>
Introduce <code>week</code> parameter to change the weather dataset.
This is for <a href=\"https://github.com/open-ideas/IDEAS/issues/1462\">#1462</a>.
</li>
<li>
July 7, 2025, by Lone Meertens:<br/>
First implementation PVT model.
This is for <a href=\"https://github.com/open-ideas/IDEAS/issues/1436\">#1436</a>.
Expand Down
8 changes: 7 additions & 1 deletion IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_Thermal.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ model PVT_UN_Thermal
replaceable package Medium = IDEAS.Media.Antifreeze.PropyleneGlycolWater (
property_T = 293.15,
X_a = 0.43);
parameter String week = "week1";
parameter Modelica.Units.SI.Temperature T_start = 17.086651 + 273.15 "Initial temperature (from measurement data)";
parameter Real eleLosFac = 0.07;

inner Modelica.Blocks.Sources.CombiTimeTable meaDat(
tableOnFile=true,
tableName="data",
fileName=Modelica.Utilities.Files.loadResource("modelica://IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements.txt"),
fileName=Modelica.Utilities.Files.loadResource("modelica://IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements_"+week+".txt"),
columns=1:26) annotation (Placement(transformation(extent={{-92,24},{-72,44}})));

Modelica.Thermal.HeatTransfer.Celsius.ToKelvin TFluKel annotation (Placement(transformation(extent={{-87,-1},
Expand Down Expand Up @@ -109,6 +110,11 @@ This filtered metric better reflects the model's accuracy under realistic operat
revisions="<html>
<ul>
<li>
September 3, 2025, by Jelger Jansen:<br/>
Introduce <code>week</code> parameter to change the weather dataset.
This is for <a href=\"https://github.com/open-ideas/IDEAS/issues/1462\">#1462</a>.
</li>
<li>
July 7, 2025, by Lone Meertens:<br/>
First implementation PVT model.
This is for <a href=\"https://github.com/open-ideas/IDEAS/issues/1436\">#1436</a>.
Expand Down
9 changes: 8 additions & 1 deletion IDEAS/Fluid/PVTCollectors/Validation/PVT_UN/package.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,18 @@ an uncovered and uninsulated PVT collector,
based on experimental data from a long-term outdoor test campaign in Austria (Veynandt et al., 2023).
</p>
<p>
The dataset spans 58 consecutive summer days with 5-second resolution, capturing a wide range of operating conditions.
The full dataset spans 58 consecutive summer days with 5-second resolution, capturing a wide range of operating conditions.
Notably, the test period includes days with several hours of very high wind speeds, reaching up to <i>10–12&nbsp;m/s</i>,
which significantly affect convective heat losses.
</p>
<p>
The full dataset was split into 8 weeks to limit the file size per dataset.
The validation models allow to change the week via the parameter <code>week</code>.
The user can also merge the files together into one dataset and
change the <code>fileName</code> parameter in the <code>meaDat</code> block
to simulate the all 58 summer days in one run.
</p>
<p>
The package includes two models:
</p>
<ul>
Expand Down
3 changes: 0 additions & 3 deletions IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements.txt
View file
Open in desktop

This file was deleted.

120,962 changes: 120,962 additions & 0 deletions IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements_week1.txt
View file
Open in desktop

Large diffs are not rendered by default.

120,962 changes: 120,962 additions & 0 deletions IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements_week2.txt
View file
Open in desktop

Large diffs are not rendered by default.

120,962 changes: 120,962 additions & 0 deletions IDEAS/Resources/Data/Fluid/PVTCollectors/Validation/PVT_UN/PVT_UN_measurements_week3.txt
View file
Open in desktop

Large diffs are not rendered by default.

Loading