Skip to content

Optimize bufio.NewScanner with bytes.NewReader #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andersendsa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Optimize bufio.NewScanner with bytes.NewReader #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion platform-manageability-agent/internal/comms/comms.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package comms

import (
"bufio"
"bytes"
"context"
"crypto/tls"
"errors"
Expand Down Expand Up @@ -142,7 +143,7 @@ func (cli *Client) IsActivationInProgress() bool {
return cli.isActivationInProgress.Load()
}
func parseAMTInfoField(output []byte, parseKey string) (string, bool) {
scanner := bufio.NewScanner(strings.NewReader(string(output)))
scanner := bufio.NewScanner(bytes.NewReader(output))
for scanner.Scan() {
line := scanner.Text()

Expand Down
3 changes: 2 additions & 1 deletion platform-update-agent/internal/utils/os_detection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ package utils

import (
"bufio"
"bytes"
"fmt"
"strings"
)
Expand All @@ -28,7 +29,7 @@ func DetectOS(reader FileReader, forcedOS string) (string, error) {
return "", fmt.Errorf("failed to open /etc/os-release: %v", err)
}

scanner := bufio.NewScanner(strings.NewReader(string(content)))
scanner := bufio.NewScanner(bytes.NewReader(content))
var osId string
for scanner.Scan() {
line := scanner.Text()
Expand Down