chore(deps): update fs-extra to 11.3.6 across all packages#328
Open
X-Guardian wants to merge 3 commits into
Open
chore(deps): update fs-extra to 11.3.6 across all packages#328X-Guardian wants to merge 3 commits into
X-Guardian wants to merge 3 commits into
Conversation
2b38d2f to
7b67260
Compare
7b67260 to
d8f238d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
fs-extrato11.3.6(and@types/fs-extrato11.0.4) in every package that depends on it, so the whole monorepo resolves a single copy of each.Before this change the versions were inconsistent: five packages were already on the
11.xline (11.3.4/^11.3.0), while three —@cdktn/provider-generator,@cdktn/cli-core, andcdktn-cli— plus the standalonetest/harness were still pinned tofs-extra@8.1.0/@types/fs-extra@8.1.5. This aligns all of them on the current release.Packages updated:
fs-extra@types/fs-extra@cdktn/provider-generator8.1.0→11.3.68.1.5→11.0.4@cdktn/cli-core8.1.0→11.3.68.1.5→11.0.4cdktn-cli8.1.0→11.3.68.1.5→11.0.4test/(non-workspace)^8.1.0→^11.3.6^8.1.5→^11.0.4@cdktn/provider-schema11.3.4→11.3.611.0.4(unchanged)@cdktn/commons11.3.4→11.3.611.0.4(unchanged)@cdktn/hcl2cdk11.3.4→11.3.611.0.4(unchanged)@cdktn/hcl2json11.3.4→11.3.611.0.4(unchanged)@cdktn/hcl-tools^11.3.0→^11.3.611.0.4(unchanged)Two source changes were required. The three packages crossing the
8.x→11.xboundary were checked against the fs-extra breaking changes in that window. The@types/fs-extra@11typings are stricter than@types/fs-extra@8and flagged two existing calls that passed arecursiveoption to a copy —fs.copy/fs.copySyncare always recursive, sorecursivewas never a validCopyOptions/CopyOptionsSynckey; the looser v8 typings silently accepted it. Removing it is a no-op at runtime:@cdktn/provider-generator/src/get/constructs-maker.ts—error TS2769onfs.copy(source, target, { recursive: true, overwrite: false })→fs.copy(source, target, { overwrite: false }).cdktn-cli/src/bin/cmds/helper/init.ts—error TS2353onfs.copySync(src, dest, { recursive: true })→fs.copySync(src, dest).No behavioural change was needed for the other differences.
move()defaulting tooverwrite: falsefrom v9 onward doesn't affect the threefs.movecall sites in the same file, which already pass{ overwrite: true }explicitly. Every other method used across these packages (existsSync,readFile(Sync),writeFile(Sync),remove(Sync),pathExists,mkdirp/mkdirs,copy(Sync),stat,readJson(Sync),appendFileSync,rmSync,unlinkSync,accessSync,constants) is unchanged from 8 through 11. The rest of the 8→11 range only dropped support for Node.js < 14, which the repo already requires.Checklist