Repository navigation
test: pin the eval CLI's cp1252 console output (IR-33) - #335
Merged
Merged
Conversation
`chock check --only evals` on a Windows cp1252 console printed U+FFFD and raised UnicodeEncodeError (IR-F31). SR-5 (#325) already escapes it in the stdout wrapper, so no code changes. This test drives the real command through a strict cp1252 stream and asserts no exception and backslash-escaped output. Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
jothimani-rajendran
marked this pull request as ready for review
October 27, 2026 03:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regression test only, no code change.
chock check --only evalsdriven through a strict cp1252 stream with U+FFFD in its output must not raise, and must write the escaped form (backslash, u, fffd).Why
IR-F31: the catalog's framework pin a2a3151 crashed with
UnicodeEncodeErroron a Windows cp1252 console. SR-5 (#325) already fixes it inPipeTolerantWriter, so the fix is the catalog's re-pin in the rc.4 regeneration.Measured (
PYTHONIOENCODING=cp1252, U+FFFD appended to the eval report)chock check --only evalspython -m chock.eval.clipython -m chock.eval.cliskipsguard_stdoutand is not a documented entry point; thechockandchock evalcommands go throughchock.cli.main.Base
rc, notmain: the test needs SR-5'spipe.py. Onmainit fails (verified by restoring main'spipe.py).Checks
ruff check and format clean;
tests/: 5168 passed, 103 skipped.