Skip to content

test: keep interpreter start-up out of the early-exit pattern-judge budget (SR-6) #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jothimani-rajendran wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: keep interpreter start-up out of the early-exit pattern-judge budget (SR-6) #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/test_pattern_deadline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,14 @@ def test_the_history_scan_needs_no_signal() -> None:


def test_the_judge_matches_times_out_and_reports_a_dead_child() -> None:
# A call that starts a child spends interpreter start-up out of its budget, and start-up on a
# loaded runner can outlast SECONDS; only the catastrophic pattern needs the short budget, and
# by then the child is already up. Every other call returns as soon as the child answers or dies.
start_up = budget.PATTERN_SECONDS
judge = budget.pattern_judge()
assert budget.judge_patterns(judge, [("a", []), ("b", [])], SECONDS) == ([[], []], None)
assert judge["proc"] is None, "nothing to judge starts no child"
assert budget.judge_patterns(judge, [("a+", ["xa", "b", "aaa"]), (r"\d", ["1", "x"])], SECONDS) == (
assert budget.judge_patterns(judge, [("a+", ["xa", "b", "aaa"]), (r"\d", ["1", "x"])], start_up) == (
[[0, 2], [0]],
None,
)
Expand All @@ -154,9 +158,9 @@ def test_the_judge_matches_times_out_and_reports_a_dead_child() -> None:
assert hits is None and why == f"the patterns gave no verdict within {SECONDS}s (a catastrophic pattern?)"
assert SECONDS <= time.monotonic() - started < budget.PATTERN_SECONDS
assert judge["proc"] is None, "a timed-out child is killed"
hits, why = budget.judge_patterns(judge, [("(", ["x"])], SECONDS)
hits, why = budget.judge_patterns(judge, [("(", ["x"])], start_up)
assert hits is None and why.startswith("the pattern judge exited early (")
assert budget.judge_patterns(judge, [("x", ["x"])], SECONDS) == ([[0]], None), "a new child after a crash"
assert budget.judge_patterns(judge, [("x", ["x"])], start_up) == ([[0]], None), "a new child after a crash"
assert budget.close_judge(judge) == "" and judge["proc"] is None


Expand Down
Loading