Repository navigation
CH-5: Windows paths in the repo stop and the Windows CI leg - #310
Merged
Merged
Conversation
repo_stop reads each shell word a second time without POSIX backslash eating and through PureWindowsPath, so `rm C:\repo\.chock\stop.json` names the repo. Baseline-selection messages name the repo-relative path with forward slashes. windows-paths.yml also runs the repo_stop, pack hash, install and scaffold test files. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
NTFS has no executable bit; the scaffold chmod is a POSIX property. Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
jothimani-rajendran
marked this pull request as ready for review
October 20, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
repo_stop._repo_stop_wordsalso splits withshlex(posix=False)and reads each word throughPureWindowsPath, sorm C:\repo\.chock\stop.jsonnames the repo (a POSIX split eats the backslashes).validation/selection_source.py) name the repo-relative path with/.windows-paths.ymlruns the repo_stop (gap1d), pack hash, install and scaffold test files; no new permissions, actions unchanged.Stacking
Stacks on #309 (CH-4, not yet merged): this branch carries a merge of #309's head (72df6a1), because
tests/test_scaffold_kinds.pyexists only there. Until #309 merges, the diff shows its commits too.Owner follow-up
repo_stopis vendored runtime, so this diff drifts.chock/bin; the owner regenerates it on the branch after merging main. The worker did not runchock sync.Not measured
Windows CI results, including the eight
test_repo_stop_gap1dparams: unmeasured until the Windows job runs. The pytest suite did not run locally (the pinned agentseam is not installable in the worker's environment); only the repo_stop function was exercised directly.