Repository navigation
feat(labels): plain-sentence policy labels, install warnings and witness notes (VOICE-3a) - #305
Merged
Merged
Conversation
…ess notes (VOICE-3a) Rewrites the label text chock install prints and the catalog registry reads (bundle_grade grade texts, the Devin and tier-table prefixes, the unasked note), the client warnings in install/data/warnings.json, the Claude Code plugin offer text, and the plugin-hook witness notes, per the org-plan voice style guide: no semicolon chains, no "judged" or "fails open". No label claims more than before and every caveat stays. Tests asserting exact copy move to the new text; plugin_targets goldens regenerated with CHOCK_REGEN_GOLDENS=1 on Python 3.13. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
…(VOICE-3a) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
…OICE-3a review) "no live run has shown a chock install working" claimed more than the original "chock has not witnessed"; it now reads "chock has not seen an install work in this client in a live run". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Jothi Mani Rajendran <250249270+jothimani-rajendran@users.noreply.github.com>
jothimani-rajendran
marked this pull request as ready for review
October 19, 2026 01:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
VOICE-3a (org-plan
plan/site-plain-voice.md). This PR rewrites the label and warning text that the site andchock installshow, following the voice style guide in org-plandiscovery/2026-10-18-site-voice-audit.md. The new text has no semicolon chains, no colon chains, and no jargon such as "judged", "fails open" or "witnessed". No label claims more than it did before, every caveat is kept, and "tested" (seen in a live run) stays separate from "vendor docs only".plugin/bundle_grade.py: changes the advisory text and the Stop-only gate reach ("blocks at turn end only. It does not check a file write when it happens"). A guard next to a gate is now joined with ". " instead of "; ".install/package.pyandinstall.json: the tier-table prefix now reads "best-effort, and a hook error lets the action through (agentseam vendor-docs): " instead of "fail mode open". The words for each fail mode now live in data. The unasked note becomes ". The ask is not enforced here (…)".install.jsonandbundle_build._QUALIFIER) is rewritten the same way.install/data/warnings.json: 15 warnings,install/data/claude_plugin.json: 6 strings, anddata/witnesses.json: 6 plugin-hook witness notes. Quoted output, ids, record paths and commits are unchanged.plugin_targetsgoldens were regenerated withCHOCK_REGEN_GOLDENS=1on Python 3.13.CHANGELOG.mdis not edited. Achangelog.d/fragment is added instead.The words the site's label tags match on ("shell command", "file writes", "turn end", "advisory") are kept. chock-catalog's
tools/label_honesty.pyis updated in the companion catalog PR so it reads both the old and the new wording.Definition of done
chock sync --repo . --checkcleanpytest -q(Python 3.13): 4683 passed, 97 skipped, 1 failed on the first run (the 300-line budget intest_plugin_install_targets.py). That is fixed in the third commit, and the file andtest_repo_standards.pywere re-run: 44 passed.changelog.d/voice-3a-plain-labels.mdfragment is added.ruff checkandruff format --checkclean onsrcandtests.tools/check_literal_duplication.pyis clean.chock checkand the acceptance suite were not run locally. CI runs them.Claims
Owner approval gate: this PR stays in draft until the owner approves the wording list in the org-plan handoff.
Generated by Claude Code