Skip to content

fix(credentials): stop re-prompting for Keychain access on every upgrade #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piekstra merged 1 commit into from
Nov 3, 2026
Merged

fix(credentials): stop re-prompting for Keychain access on every upgrade #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,14 @@ for the current user.
| Windows | Credential Manager |
| Linux | Secret Service |

On macOS, `cr` reads Keychain secrets through the system `/usr/bin/security`
executable, so access granted once carries across `cr` upgrades. The first read
of an item that does not yet trust `security` raises one prompt naming `security`;
choose **Always Allow**. Reads of that item do not prompt again. `cr set-credential`
and other writes still run as the `cr` binary, and a newly created item raises that
one prompt on its first read. A prompt left unanswered fails the read after 60
seconds.

Configured stores can also target `1Password` desktop, service account, or
Connect backends, `pass`, encrypted file storage, or in-memory storage. Configure
additional stores from interactive `cr init` under **Configure secrets
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ require (
github.com/creack/pty v1.1.24
github.com/gobwas/glob v0.2.3
github.com/google/uuid v1.6.0
github.com/open-cli-collective/cli-common v0.4.1
github.com/open-cli-collective/cli-common v0.5.1
github.com/spf13/cobra v1.10.2
go.yaml.in/yaml/v3 v3.0.5
golang.org/x/image v0.47.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@ github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e h1:fD57ERR4JtEqsWb
github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e/go.mod h1:zD1mROLANZcx1PVRCS0qkT7pwLkGfwJo4zjcN/Tysno=
github.com/noamcohen97/touchid-go v0.3.0 h1:fcXxVCizysD7KHRR6hrURt3nyNIs5JBGSbOIidD/3wo=
github.com/noamcohen97/touchid-go v0.3.0/go.mod h1:X9MRNIBGEmPqwpDm1G3fQOAQX7fwBlhzUbnkDTxuta0=
github.com/open-cli-collective/cli-common v0.4.1 h1:6oNaUVmMtXWi4pJn1X+W6KZVDP/WAJwbyZUyxYpGdbQ=
github.com/open-cli-collective/cli-common v0.4.1/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ=
github.com/open-cli-collective/cli-common v0.5.1 h1:BbCngljAqHyxtfyQ680qOzn/IYIAOZRldDQvPKJuZ2o=
github.com/open-cli-collective/cli-common v0.5.1/go.mod h1:3AzjCT0V8xgslHlGi1+rUkcV+Vf5wONGwISQkufLZLQ=
github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=
github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
Expand Down
Loading